Repository navigation
Conversation
Storing a record answered 201 whether the key was new or not. An overwrite now answers 200, so a client can tell a first write from an update. Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_017ocuAL43YR6VPaBRrRfBbL
Contributor
|
Platform parity:
Reviewed commit: f6ac1f2 |
apify-factory
suggested changes
Nov 3, 2026
apify-factory
left a comment
apify-factory
left a comment
There was a problem hiding this comment.
One thing to fix before merge.
| await store.setValue(recordKey, body, { contentType }); | ||
| await touchStorage(record.id); | ||
| res.status(201).end(); | ||
| res.status(existed ? 200 : 201).end(); |
There was a problem hiding this comment.
Important: the real platform answers 201 to every record store, overwrite or not (apify-core src/api/src/routes/key_value_stores/record.ts:168, res.status(201).json({})), and requirements/ documents no difference, so an overwrite answering 200 makes the emulator diverge from the platform in a way clients can observe.
apify-factory
suggested changes
Nov 3, 2026
apify-factory
left a comment
apify-factory
left a comment
There was a problem hiding this comment.
One thing to fix before merge.
Outside the diff:
src/api/routes/key-value-stores.ts: Important: the real platform answers201for every record write, new key or overwrite (apify-coresrc/api/src/routes/key_value_stores/record.ts:168), andrequirements/storage.md's "Known differences" does not list this, so an overwrite answering200here is an undocumented divergence that code relying on the platform's behavior will observe.
Pijukatel
changed the base branch from
claude/ecstatic-euler-ki5zev
to
claude/review-references
November 3, 2026 10:38
Collaborator
Author
|
Comparing platform parity review with enhanced context apify_factory review. Seems to be working fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storing a record answered
201whether the key was new or already there. An overwrite now answers200, so a client can tell a first write from an update without a second request.