Repository navigation
fix: unlock a deferred task so it runs again - #122
Open
david-mccullars wants to merge 1 commit into
Open
david-mccullars wants to merge 1 commit into
david-mccullars wants to merge 1 commit into
Conversation
A handler that returns DeferredError or RetryAfterError sends the task back to Pending, but the ack left it locked by the worker that ran it. fetch_next only takes Pending tasks with no lock, so the task was never fetched again. The ack now clears the lock when it returns a task to Pending. Closes apalis-dev#121
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #121
A task deferred with
DeferredErrororRetryAfterErrorgoes back toPendingbut keeps its worker's lock, so it is never fetched again. The ack now clears the lock when it sends a task back toPending.RetryAfterError's delay never reaches the backend, so the task runs again on the next fetch. Honouring the delay would need a change in apalis-core.Type of Change
Testing
cargo fmtandcargo clippydeferred_task_runs_againdefers a task once and expects it to run a second time. Onmainit times out.Checklist