Repository navigation
optee-teec: fix ConnectionMethods login codes and Context/Session Send-safety - #328
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related
optee-teecfixes:Correct
ConnectionMethodslogin-code mapping.ConnectionMethodspreviously derived its discriminants implicitly, butTEEC_LOGIN_APPLICATION,TEEC_LOGIN_USER_APPLICATIONandTEEC_LOGIN_GROUP_APPLICATIONare0x4,0x5,0x6(there is no0x3),so
login as u32could pass a non-existent login code toTEEC_OpenSession. The variants are now pinned to theTEEC_LOGIN_*constants with
#[repr(u32)]andnum_enum, with anUnknown(u32)catch-all and a round-trip unit test covering every constant.
Remove hand-written
Send/SyncfromContextandSession.Contextnow holdsArc<Mutex<InnerContext>>, which is automaticallySend + Syncbecauseraw::TEEC_Contextcontains only scalars.Sessionstores the opaque handle in a privateRawTeecSession(raw::TEEC_Session)wrapper. A single, documentedunsafe impl Sendlives on that wrapper;Sessionitself is derived.optee-teec-sysis untouched.