Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import java.io.Serializable;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Comparator;
import java.util.HashSet;
import java.util.LinkedHashMap;
import java.util.LinkedHashSet;
Expand Down Expand Up @@ -517,6 +518,26 @@ public Builder addActionConfig(String name, ActionConfig action) {
return this;
}

/**
* Re-inserts this package's action configs into a new insertion-ordered map,
* ordered by the supplied comparator over the action-name keys. Must be called
* before {@link #build()}.
*
* @param byActionName comparator over action names determining match precedence
* @return this builder
* @since 7.3.0 (WW-3784)
*/
public Builder reorderActionConfigs(Comparator<String> byActionName) {
List<Map.Entry<String, ActionConfig>> entries = new ArrayList<>(target.actionConfigs.entrySet());
entries.sort(Map.Entry.comparingByKey(byActionName));
Map<String, ActionConfig> reordered = new LinkedHashMap<>();
Comment thread
lukaszlenart marked this conversation as resolved.
for (Map.Entry<String, ActionConfig> entry : entries) {
reordered.put(entry.getKey(), entry.getValue());
}
target.actionConfigs = reordered;
return this;
}

public Builder addParents(List<PackageConfig> parents) {
for (PackageConfig config : parents) {
addParent(config);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.struts2.config.entities;

import junit.framework.TestCase;

import java.util.ArrayList;
import java.util.Comparator;
import java.util.List;

public class PackageConfigBuilderReorderTest extends TestCase {

public void testReorderActionConfigsAppliesComparator() {
PackageConfig.Builder builder = new PackageConfig.Builder("test");
builder.addActionConfig("some/*", action("some/*"));
builder.addActionConfig("some/usefull/*", action("some/usefull/*"));

// reverse-alphabetical proves the map is genuinely reordered, not left as-inserted
builder.reorderActionConfigs(Comparator.reverseOrder());

List<String> keys = new ArrayList<>(builder.build().getActionConfigs().keySet());
assertEquals(List.of("some/usefull/*", "some/*"), keys);
}

private ActionConfig action(String name) {
return new ActionConfig.Builder("test", name, "com.example.Action").build();
}
}
Loading
Loading