Repository navigation
#2199 BasicURLNormalizer: split the query on & only, not on ; - #2260
Open
GitMehdi-sys wants to merge 1 commit into
Open
GitMehdi-sys wants to merge 1 commit into
GitMehdi-sys wants to merge 1 commit into
Conversation
GitMehdi-sys
force-pushed
the
fix-2199-query-separator
branch
from
October 23, 2026 19:53
b5e003f to
d093e2c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2199
BasicURLNormalizer parsed the query with URLEncodedUtils.parse(query, UTF_8), which treats both & and ; as separators, so a ; used as ordinary data (e.g. ?q=a;b) was split into two parameters. It now passes '&' as the only separator, following the URL Standard.
Behaviour note: the query is still rebuilt with URLEncodedUtils.format(), which percent-encodes ';' like the other characters the normaliser already canonicalises, so q=a;b becomes q=a%3Bb (a single parameter that decodes to the same value) instead of being split into b&q=a. Existing tests all expect re-encoding (e.g. ! -> %21), so I kept that.
Tests: added testSemicolonIsNotAQuerySeparator, which fails without the fix. All 719 core tests pass.