Repository navigation
Bind RAT license check into the default build - #3
Merged
Merged
Conversation
The Apache parent pom only runs apache-rat:check in the apache-release profile, so plain mvn verify never enforced license headers. Bind an execution to the validate phase so verify (and CI) fails on missing headers. Fix the two existing violations: exclude the generated uv.lock, and give AGENTS.md a compact SPDX header comment (the markdown form used by Apache Magpie).
Contributor
|
Thank you ! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Apache parent pom only runs
apache-rat:checkin theapache-releaseprofile, so plainmvn verify(and the CI added in #2) never actually enforced license headers, despite the plugin being configured. This binds arat-checkexecution to thevalidatephase so everymvn -B verifyrun enforces them.Fixes the two violations that surfaced once RAT actually ran:
uv.lock— generated lockfile, added to the RAT excludes;AGENTS.md— given a compact SPDX header in an HTML comment ( RAT 0.16 recognizes SPDX identifiers).Verified locally:
mvn -B verifynow showsRat check: ... Unapproved: 0and stays green alongside Spotless and Checkstyle.