Repository navigation
Conversation
github-actions
Bot
added
the
documentation
| names = {"--solr-include-file"}, | ||
| paramLabel = "FILE", | ||
| required = true, | ||
| // Always supplied by bin/solr (from SOLR_INCLUDE); hidden because a user-supplied copy would |
There was a problem hiding this comment.
maybe more concise comment possible? get to one line?
| } | ||
|
|
||
| # Utility function for asserting between the commons-cli wording ($1), or, when running against the picocli CLI, the picocli wording ($2) | ||
| # Todo: Remove this once commons-cli cleanup happens |
There was a problem hiding this comment.
i think in java code it's "TODO", do we actually have any reports that highlihgt todo code items?
There was a problem hiding this comment.
Renamed to TODO.
Actually I am not aware of any such report which picks up our TODOs, i added it as a marker for the cleanup of commons-cli.
| # The auth command exports some system variables that are injected as basic auth username and password, | ||
| # however that defeats our test so fake that out via --solr-include-file param specifing a bogus path. | ||
| solr auth enable --type basicAuth --credentials name:password --solr-include-file /force/credentials/to/be/supplied | ||
| SOLR_INCLUDE=/force/credentials/to/be/supplied solr auth enable --type basicAuth --credentials name:password |
There was a problem hiding this comment.
if the way to pass this setting in is via a system property, that maybe begs teh question why do we have the parameter at all?
There was a problem hiding this comment.
not fully sure about this aspect as of now. will have to dig little deeper here.
|
|
||
| @test "solr help flag prints help" { | ||
| run -1 solr --help | ||
| assert_output --partial 'Usage: solr COMMAND OPTIONS' |
There was a problem hiding this comment.
i know we are doing "the right thing", but a part of me just wishes we removed the commons-cli testing at this point... but this is "the right way"...
There was a problem hiding this comment.
yes, this is to facilitate a smoother migration.
+1 this feels like the right way, once we ensure stablity of picocli, this all goes away then.
| *-s*, *--solr-connection*=_<solrConnection>_:: | ||
| Zookeeper or HTTP(s) connection string; unnecessary if SOLR_CONNECTION is defined in solr.in.sh; otherwise, defaults to localhost:9983. | ||
|
|
||
| *--solr-include-file*=_FILE_:: |
There was a problem hiding this comment.
why can't we just keep this? Or is this just a property that no one uses, so we simplifeid by making it a system property?
There was a problem hiding this comment.
i am not fully confident on this aspect, will try digging more here.
https://issues.apache.org/jira/browse/SOLR-18566
Description
Follow-up PR for:
Solution
Used Cursor for debugging help, code contribution is fully vetted by Jalaz Kumar.
Tests
4 bats tests:
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.