Repository navigation
Conversation
Contributor
Author
|
/no-changelog |
Contributor
Author
Testing Evidences
|
Contributor
|
Agreed no changelog needed |
epugh
reviewed
Oct 17, 2026
epugh
left a comment
epugh
left a comment
Contributor
There was a problem hiding this comment.
This makes sense.... however do we need to document in the ref guide the two different out puts? Between v1 and v2?
The V1/V2 full-config output comparison only called out the children-key difference; add the searchComponent/queryResponseWriter pluralization this PR introduces, shown the same way as the existing children-key example (separate V1/V2 JSON output per tab). Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01RzzUgiebQ8ZhhgE2E7ZZU5
github-actions
Bot
added
the
documentation
The new V1/V2 full-config diff duplicated the elevator/xslt example and explanation already given a few dozen lines down, where the per-section GET endpoints are documented. Drop the redundant JSON snippets and keep a single forward-pointing sentence instead. Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01RzzUgiebQ8ZhhgE2E7ZZU5
reqhandlertests() is shared between v1 and v2 harness runs (toggled randomly in @before), and asserted the singular "searchComponent" key against the bare /config endpoint regardless of API version. Since GetConfig#getConfig now pluralizes that key under v2, the test failed whenever the random toggle picked v2 (reproduced with CI's exact seed 177EED04838EDD3C). Pick the expected key based on the harness's URL. Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01RzzUgiebQ8ZhhgE2E7ZZU5
Contributor
Author
thanks @epugh for doing ref guide updates this time. I will try keeping them in sync from next PRs. can we retrigger the workflows & verify once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16396
Description
Align v2 full-config section keys with pluralised forms
Solution
Since, this is an ongoing initiative, imo no CL is required here.
Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.