Repository navigation
SOLR-18526: Fix the start commands in the SSL guide - #5121
Conversation
Since Solr 10 a bare `bin/solr start` starts SolrCloud, so the SSL page's user-managed example needs `--user-managed`; `solr.cmd` ignores a command that does not begin with `start`. The mode was also called "standalone" and "User Managed" in places; the guide's own cluster-types page names it user-managed.
github-actions
Bot
added
the
documentation
epugh
left a comment
epugh
left a comment
There was a problem hiding this comment.
I like the consistency... And as I look at our weird straddeling of "user managed / standalone" phrasing, I like the elimination of "standalone", because our start param is --user-managed. Having said that, I wish we had bin/solr start --standalone, but that would be something new to discuss.
|
|
||
| [%hardbreaks] | ||
| # Start in user managed mode | ||
| # Start in user-managed mode |
There was a problem hiding this comment.
Not sure we need the dash here?
| [source,powershell] | ||
| ---- | ||
| bin\solr.cmd --solr-home cloud\node1 -z server1:2181,server2:2181,server3:2181 | ||
| bin\solr.cmd start --solr-home cloud\node1 -z server1:2181,server2:2181,server3:2181 |
| ==== User-Managed Mode | ||
|
|
||
| `bin/solr start --user-managed` starts Solr in User Managed mode (AKA Standalone mode). This was the default mode up until Solr 10x. | ||
| `bin/solr start --user-managed` starts Solr in user-managed mode (also called standalone mode). This was the default mode up until Solr 10x. |
There was a problem hiding this comment.
i like this better phrasing better. AKA was werid. Having said that, I wonder if using the phrase "user-managed" versus "User Managed" is the way to go. I mean, maybe? What about "in user managed mode". DO we need the dash? We have it in the bin/solr start --user-managed, but maybe we don't need it hyponentaed everywhere?
| ==== | ||
|
|
||
| V2 API User-Managed / Standalone Solr:: | ||
| V2 API User-Managed:: |
There was a problem hiding this comment.
This really does read much nicer...
|
@dsmiley I seem to recall you had strong opinons about "user managed" versus "standalone". This PR really shifts us towards the "user managed" name, and reduces the use of the word "Standalone". I'd love your input. Do we want to relitigate the name, and maybe even change bin/solr start to being |
checkCliDocsUpToDate fails when the .adoc terminology differs from the picocli source.
dsmiley
left a comment
dsmiley
left a comment
There was a problem hiding this comment.
The degree to which I hate the over-use of "user managed" I see here really gets to me to perhaps irrational levels but I'm being honest. This really animates me! Sorry I must veto this.
I am bringing this to the list.
|
That is why I tagged you! I think we need to finally resolve this naming conundrum. |
…ands # Conflicts: # solr/solr-ref-guide/modules/deployment-guide/pages/user-managed-index-replication.adoc
|
@serhiy-bzhezytskyy okay, we have a sharp u-turn being performed! BAsed on https://lists.apache.org/thread.html/y6x19tr56d1s3t7klk2jmsbxsfn3dmoj we are going with --standalone and "standalone" terminology and erradication "user managed". We need to keep --user-managed for any 10.0 users, but it's deprecated and can be removed in solr 11.... I don't know if you want to update this PR or close and make a new one???? |
|
also, I notice the title is SOLR-18526, but myabe this is actually fixing SOLR-18500? |
The Windows examples left out the start subcommand, which bin\solr.cmd requires, and the standalone example started SolrCloud because it lacked --user-managed.
serhiy-bzhezytskyy
changed the title
|
Thanks for spotting that: the description was the text of #5120 (SOLR-18500). Reworked: the terminology changes are gone and only the start-command fixes remain, so SOLR-18526 stays. I'll leave the rename to your change. |
(cherry picked from commit 4422d26)
3 participants
https://issues.apache.org/jira/browse/SOLR-18526
Description
bin\solr.cmdneeds thestartsubcommand, and two Windows examples in the SSL guide leave it out. The standalone example,bin/solr start -p 8984, starts SolrCloud, because--user-managedis missing.Solution
startadded to the two Windows examples,--user-managedto the two standalone ones. The system info page said "the mode Solr is running in standalone mode"; it now says whatstdmeans.Written with Claude Code.
Checklist
mainbranch../gradlew check.