Repository navigation
SOLR-18500: Single-quote the URL in every curl example - #5120
Open
serhiy-bzhezytskyy wants to merge 3 commits into
Open
serhiy-bzhezytskyy wants to merge 3 commits into
serhiy-bzhezytskyy wants to merge 3 commits into
Conversation
A single-quoted URL reaches curl as written, so a copied example does what the page says. Eleven unquoted examples did not: the shell ended the URL at `&` or read `<signature>` as a redirect. URLs that need `$VAR` expansion or escapes stay double-quoted; `-X` now comes before the URL and is dropped where curl implies it.
That page is rewritten in SOLR-18499, which also single-quotes its curl examples.
Contributor
Contributor
|
@janhoy @gerlowskija would love your opinon on the visual look of these CURL commands, see the one above! |
…uoting # Conflicts: # solr/solr-ref-guide/modules/deployment-guide/pages/cluster-node-management.adoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


https://issues.apache.org/jira/browse/SOLR-18500
Description
Of 510
curlcommands in the Ref Guide, the URL is single-quoted in 161, double-quoted in 89 and unquoted in 190. Eleven of the unquoted ones cannot be copied as written: the shell ends the URL at&or reads<signature>as a redirect.Solution
Every URL is single-quoted, except the 6 that need shell escapes or
$VARexpansion, and the v2 API page, which SOLR-18499 rewrites.-X GETand-XPOSTnext to-dare dropped, and-X POSTin the-Texample moves before the URL.Written with Claude Code.
Tests
For each of the 263 commands that only changed quotes, bash passes
curlthe same arguments before and after. The 11 unquoted ones now pass the whole URL.buildLocalAntoraSiteandcheckSiteLinkspass.Checklist
mainbranch../gradlew check.