SOLR-12613: node picker for cross-node screens by iprithv · Pull Request #5110 · apache/solr

iprithv · 2026-10-12T14:39:23Z

https://issues.apache.org/jira/browse/SOLR-12613

HACKATHON :)

added a Node picker so Thread Dump, Java Properties, Logging, Cores, and Dashboard can target any live node via the existing nodes= proxy.

sidebar is split into Cluster and Node. Works in SolrCloud and stays out of the way in standalone.

…d Cluster/Node sidebar. Signed-off-by: prithvi <[email protected]>

iprithv · 2026-10-12T14:51:05Z

Signed-off-by: prithvi <[email protected]>

… tests. Signed-off-by: prithvi <[email protected]>

janhoy · 2026-10-12T18:25:50Z

First question: The "node selector" dropdown, I suppose will still be valid only for the current node, i.e. query, update, schema, segments etc etc? Users may believe that it also obeys the chosen node. Not sure how to deal with that.

Copilot

🟡 Changes recommended

Persisted targets can display local data as remote, and remote Core Admin views can execute mutations against the wrong node.

6 open findings

What changed in this PR

Adds cross-node targeting to the legacy Admin UI and supporting V2 node APIs.

Changes:

Adds a persistent live-node picker and reorganizes the sidebar.
Extends node-local APIs with nodes proxy support.
Adds backend proxy integration tests and UI styling.

File	Description
`solr/webapp/web/partials/logging-levels.html`	Adds cluster-wide logging notice.
`solr/webapp/web/partials/index.html`	Displays the selected node.
`solr/webapp/web/partials/cores.html`	Uses cloud-mode state consistently.
`solr/webapp/web/partials/cloud.html`	Adds node dashboard and Admin UI links.
`solr/webapp/web/js/angular/services.js`	Introduces persistent node-target state.
`solr/webapp/web/js/angular/controllers/threads.js`	Targets thread dumps by node.
`solr/webapp/web/js/angular/controllers/logging.js`	Targets log messages and adjusts level broadcasting.
`solr/webapp/web/js/angular/controllers/java-properties.js`	Targets Java properties by node.
`solr/webapp/web/js/angular/controllers/index.js`	Targets dashboard system information.
`solr/webapp/web/js/angular/controllers/cores.js`	Loads core status from selected nodes.
`solr/webapp/web/js/angular/controllers/collection-overview.js`	Guards missing collection data.
`solr/webapp/web/js/angular/controllers/cloud.js`	Connects node rows to target selection.
`solr/webapp/web/js/angular/app.js`	Integrates node state into navigation.
`solr/webapp/web/index.html`	Adds the node picker and reorganized menu.
`solr/webapp/web/css/angular/menu.css`	Styles the reorganized sidebar and selectors.
`solr/webapp/web/css/angular/logging.css`	Styles the logging notice.
`solr/webapp/web/css/angular/common.css`	Styles the selected-node badge.
`solr/webapp/web/css/angular/cloud.css`	Styles node Admin UI links.
`solr/core/src/test/org/apache/solr/handler/admin/ThreadDumpHandlerTest.java`	Adapts thread-dump tests.
`solr/core/src/test/org/apache/solr/handler/admin/api/NodeLoggingAPITest.java`	Adapts logging API tests.
`solr/core/src/test/org/apache/solr/handler/admin/api/NodeAdminProxySolrCloudTest.java`	Tests proxied node APIs.
`solr/core/src/java/org/apache/solr/handler/admin/ThreadDumpHandler.java`	Adapts the V1 thread handler.
`solr/core/src/java/org/apache/solr/handler/admin/LoggingHandler.java`	Adapts the V1 logging handler.
`solr/core/src/java/org/apache/solr/handler/admin/api/NodeThreadsAPI.java`	Adds thread-dump proxying.
`solr/core/src/java/org/apache/solr/handler/admin/api/NodeLogging.java`	Adds logging-read proxying.
`solr/core/src/java/org/apache/solr/handler/admin/api/GetNodeProperties.java`	Adds properties proxying.
`solr/core/src/java/org/apache/solr/handler/admin/api/CoreStatus.java`	Adds core-status proxying.
`solr/api/src/java/org/apache/solr/client/api/model/NodeThreadsResponse.java`	Supports keyed remote responses.
`solr/api/src/java/org/apache/solr/client/api/model/NodePropertiesResponse.java`	Supports keyed remote responses.
`solr/api/src/java/org/apache/solr/client/api/model/LoggingResponse.java`	Supports keyed remote responses.
`solr/api/src/java/org/apache/solr/client/api/model/CoreStatusResponse.java`	Supports keyed remote responses.
`solr/api/src/java/org/apache/solr/client/api/endpoint/NodeThreadsApi.java`	Adds the `nodes` parameter.
`solr/api/src/java/org/apache/solr/client/api/endpoint/NodePropertiesApi.java`	Adds the `nodes` parameter.
`solr/api/src/java/org/apache/solr/client/api/endpoint/NodeLoggingApis.java`	Adds logging `nodes` parameters.
`solr/api/src/java/org/apache/solr/client/api/endpoint/CoreApis.java`	Adds core-status node targeting.
`changelog/unreleased/PR#5110-admin-ui-node-picker.yml`	Documents the feature.

🧠 Review effort: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+        CoresV2.getAllCoreStatus(NodeTarget.withNodes({}), function(error, data, response) {
          $timeout(function() {
            if (error) { ApiErrorHandler.handle(response); return; }
+            var payload = NodeTarget.unwrap(data, response) || {};


Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

iprithv · 2026-10-12T21:55:30Z

First question: The "node selector" dropdown, I suppose will still be valid only for the current node, i.e. query, update, schema, segments etc etc? Users may believe that it also obeys the chosen node. Not sure how to deal with that.

yeah.. picker is only for the Node screens. core menu already hides on a remote node, and i added a "Node screens only" hint :)

iprithv · 2026-10-12T22:05:11Z

+                            ng-options="node as nodeLabel(node) for node in liveNodes"></select>
+                  </div>
+                  <p id="node-selector-hint" ng-class="{remote: viewingRemoteNode}">
+                    {{ viewingRemoteNode ? 'Remote node (Node screens only)' : 'This node — Node screens only' }}


I'm not convinced with this either...any better messaging which would help hre? @janhoy

Signed-off-by: prithvi <[email protected]>

janhoy · 2026-10-20T11:30:31Z

@dsmiley Do you feel strongly about this vs your approach in #5112 ?

David's more generic solution would proxy individual requests rather than aggregate, and would require the Admin UI to send N individual requests to the localhost:8983/solr/admin/foo endpoint with a header X-Solr-targetNode: otherNode3:8983_solr.

What I like the most about the ServletFilter approach is that the response shape stays the same and is thus more true to REST / OpenAPI. I.e. AdminUI can use a generated V2 API class to talk to logging / threads / xxx endpoint and get the response as an object. Less special code in UI, and less special code in Solr.

What I like with the current PR is that it is ready, mergable and re-uses the same mechanism already used in AdminUI. It could ship in 10.2 and a refactor to X-Solr-targetNode could ship in a later version.

dsmiley · 2026-10-20T17:43:36Z

I feel strongly in favor of the generic approach for the reasons you stated. I think it's also less code to maintain in the long run once the former mechanism can be removed. I'm ready to pursue my draft PR #5112 further... I was seeking feedback overall.

LoggingController's log-message-history screen already followed NodeTarget, but LoggingLevelController's listAllLoggersAndLevels call never did, even though the backend endpoint already accepts nodes= (added by this same PR). Picking a remote node had no effect on the Level tree, silently showing local data while every other node-scoped screen correctly switched. Also fixes isNodeScopedPage's page-name regex in app.js, which recognized 'logging' (the history screen) but not 'logging-levels' (the Level screen), so the header's selected-node badge never rendered there even once the data was correctly node-scoped. Adds testLoggingLevelsScreenFollowsSelectedNode to close the test gap.

Backend (reuse + altitude, confirmed by independent review agents): - Add NodeProxyingJerseyResponse, housing the remoteNodeData field and its @JsonAnyGetter/@JsonAnySetter pair that CoreStatusResponse, LoggingResponse, NodePropertiesResponse, and NodeThreadsResponse each carried as identical copies. They now extend it instead of SolrJerseyResponse directly (ListLevelsResponse/LogMessagesResponse get it for free via their existing LoggingResponse parent). - Add V2SolrRequestBasedProxy.proxyToNodes(CoreContainer, SolrRequest, NodeProxyingJerseyResponse), a generic static helper replacing five near-identical private proxy methods in CoreStatus, GetNodeProperties, NodeLogging (x2), and NodeThreadsAPI. Also drops CoreStatus's stray extra nodes-null/empty guard, which was inconsistent with the other four call sites and already redundant (proxyRequest() already no-ops via shouldProxy() when nodes is unset). Frontend: - services.js: NodeTarget.unwrap()'s data.remoteNodeData[...] fallback branch was dead - confirmed empirically (a live 2-node cluster's raw JSON response) that @JsonAnyGetter flattens remoteNodeData's entries to the top level, so a literal 'remoteNodeData' key never appears on the wire; the body[selectedNode] branch above it is what actually matches. - app.js: resetMenu() fetched core status eagerly, then a second time after listClusterNodes resolved the selected node in cloud mode, discarding the first result; the eager call is now skipped once isCloudEnabled is known true. onSelectedNodeChange() also fetched cores manually right before .reload(), which re-fetches them anyway via resetMenu() before anything renders. Verified with the existing test suites (no behavior change): backend NodeAdminProxySolrCloudTest, NodeLoggingAPITest, ThreadDumpHandlerTest; frontend AdminUiNodePickerTest, AdminUiCoreAdminStandaloneTest, plus a broader Selenium sweep (AdminUiDashboardTest, AdminUiCoreAdminScreenTest, AdminUiLoggingScreenTest, AdminUiLoggingStandaloneTest, AdminUiNodeScreensTest, AdminUiCollectionsScreenTest, AdminUiSmokeTest) since resetMenu/onSelectedNodeChange are shared by every page.

epugh · 2026-10-21T17:20:58Z

Poking more at this... I don't think we need the "this node" text:

and in fact I would just use this styling for any node:

cause after I get over the "hey, this is so cool I can connect any node", I don't actually care that it's "this node" or "remote node"! If you are a long time solr users you are excited. a new user is like, of course i can connect to any node.

epugh · 2026-10-21T17:21:49Z

SO I also think in the node selection we don't even need the text:

I would drop the Remote node (Node screens only) and his node (Node screens only) text.

epugh · 2026-10-21T17:23:01Z

This also makes me wonder if we need this duplicated gray text:

epugh · 2026-10-21T17:24:55Z

@iprithv can you review my two commits?

@test

The file's other two @test methods carry no javadoc; their names already say what they verify. This one's comment added nothing a reader couldn't get from testLoggingLevelsScreenFollowsSelectedNode itself.

…loud test LoggingResponse's new remoteNodeData field duplicated the exact same Map + @JsonAnyGetter/@JsonAnySetter pair already carried by NodeSystemResponse (pre-existing on main, backing GetNodeSystemInfo, which this PR's own description says it mirrors). Extracted a shared NodeProxyingJerseyResponse base; both now extend it instead of SolrJerseyResponse directly, and LoggingResponse's net-new addition is just failedNodes. This NodeProxyingJerseyResponse is intentionally identical to the one introduced in PR apache#5110, which independently deduplicates the same pattern across CoreStatusResponse/NodePropertiesResponse/ NodeThreadsResponse/LoggingResponse. Doing the same extraction here means neither PR depends on the other's merge order: whichever lands first, the other's rebase over the shared class is close to a no-op rather than a real conflict. Also converted NodeLoggingNodesSolrCloudTest from hand-built GenericV2SolrRequest + raw JSON tree assertions to the generated LoggingApi.ModifyLocalLogLevel/ListAllLoggersAndLevels clients with typed LoggingResponse/ListLevelsResponse assertions, matching this PR's own NodeLoggingAPITest and the Testing V2 APIs convention (apis-v2-conventions.adoc) of exercising the generated codegen rather than bypassing it. Verified: NodeLoggingAPITest 8/8, NodeLoggingNodesSolrCloudTest 4/4, LoggingHandlerTest 1/1, NodeSystemInfoProviderTest 2/2, GetNodeSystemInfoSolrCloudTest 1/1, GetNodeSystemInfoTest 1/1.

iprithv · 2026-10-22T19:01:04Z

I was checking with some production scenarios in mind and i saw these two issues. I tried setting hostnames longer as in prod and this happens in that case.

iprithv · 2026-10-22T19:03:15Z

I fixed the issue by adding horizontal scroll to both and fixed length of outline for these two

iprithv · 2026-10-22T19:04:13Z

also removed the duplicate grey node and "this node" tag :)

epugh · 2026-10-22T19:13:28Z

nice...

dsmiley · 2026-10-22T20:29:34Z

@epugh -- be aware that the implications of Jan and I preferring a generic proxy (#5112 coming soon; tests pass) means that much of the LOC here shouldn't be committed as-such.

github-actions Bot added admin-ui tests cat:api labels Oct 12, 2026

Admin UI: node picker with cross-node proxy for node-local screens an…

fc0b096

…d Cluster/Node sidebar. Signed-off-by: prithvi <[email protected]>

iprithv force-pushed the admin-ui-node-picker branch from 4915123 to fc0b096 Compare October 12, 2026 14:41

iprithv added 2 commits October 12, 2026 16:08

Add changelog and fix Spotless formatting for node picker PR.

d6b57fd

Signed-off-by: prithvi <[email protected]>

Fix Admin UI collection selector Chosen rebind TypeErrors in Selenium…

652eed6

… tests. Signed-off-by: prithvi <[email protected]>

iprithv changed the title ~~node picker for cross-node screens~~ SOLR-12613: [HACKATHON] node picker for cross-node screens Oct 12, 2026

iprithv changed the title ~~SOLR-12613: [HACKATHON] node picker for cross-node screens~~ SOLR-12613: node picker for cross-node screens Oct 12, 2026

janhoy self-requested a review October 12, 2026 18:24

janhoy requested a balanced review from Copilot October 12, 2026 18:25

Copilot started reviewing on behalf of janhoy October 12, 2026 18:26

View session

Copilot AI reviewed Oct 12, 2026

View reviewed changes

janhoy requested a balanced review from Copilot October 12, 2026 21:54

Copilot AI reviewed Oct 12, 2026

iprithv commented Oct 12, 2026

View reviewed changes

review chnge

996861b

Signed-off-by: prithvi <[email protected]>

iprithv force-pushed the admin-ui-node-picker branch from 2365a02 to 996861b Compare October 12, 2026 22:28

janhoy requested a review from dsmiley October 20, 2026 11:20

epugh added 2 commits October 21, 2026 12:58

Drop javadoc that just restated the test method's own name

3d490dc

The file's other two @test methods carry no javadoc; their names already say what they verify. This one's comment added nothing a reader couldn't get from testLoggingLevelsScreenFollowsSelectedNode itself.

epugh mentioned this pull request Oct 22, 2026

SOLR-15823: Broadcast V2 logging level changes to named nodes and migrate the Admin UI to V2 #5030

Merged

review changes and few tweaks

30d5229

Conversation

iprithv commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iprithv commented Oct 12, 2026

Uh oh!

janhoy commented Oct 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

iprithv commented Oct 12, 2026

Uh oh!

iprithv Oct 12, 2026

Choose a reason for hiding this comment

Uh oh!

janhoy commented Oct 20, 2026

Uh oh!

dsmiley commented Oct 20, 2026

Uh oh!

epugh commented Oct 21, 2026

Uh oh!

epugh commented Oct 21, 2026

Uh oh!

epugh commented Oct 21, 2026

Uh oh!

epugh commented Oct 21, 2026

Uh oh!

iprithv commented Oct 22, 2026

Uh oh!

iprithv commented Oct 22, 2026

Uh oh!

iprithv commented Oct 22, 2026

Uh oh!

epugh commented Oct 22, 2026

Uh oh!

dsmiley commented Oct 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

iprithv commented Oct 12, 2026 •

edited

Loading