[ISSUE #221] Add imagePullSecrets to operator helm chart SA - #222
[ISSUE #221] Add imagePullSecrets to operator helm chart SA#222minakoto00 wants to merge 2 commits into
imagePullSecrets to operator helm chart SA#222Conversation
|
@caigy Thank you. Kindly asking when is it gonna to be merged? |
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #222 — [ISSUE #221] Add imagePullSecrets to operator helm chart SA
Type: Enhancement (2 files, +8/-1)
Assessment
Adds configurable imagePullSecrets to the service account template, enabling deployment with private container registries. Minimal change with clear purpose.
Verdict
✅ Simple, well-scoped addition. Already approved by @caigy.
🤖 Automated review by oss-sentinel-ai
|
This PR has conflicts with the git fetch origin
git checkout master
git rebase origin/master
# resolve conflicts, then:
git push --force-with-leaseThis is a one-time reminder. Feel free to @mention me for a re-review after conflicts are resolved. Automated notification by github-manager-bot |
What is the purpose of the change
Close #221.
Why: When building operator image with different rocketmq version and pushed to private registry that requires auth, imagePullSecrets are needed.
How: Added configurable
imagePullSecretstovalues.yamland corresponding template toserviceaccount.yamlBrief changelog
Verifying this change
Please go through this checklist to help us incorporate your contribution quickly and easily.
Notice:
It would be helpful if you could finish the following checklist (the last one is not necessary) before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.make docker-buildto build docker image for operator, try your changes from Pod inside your Kubernetes cluster, not just locally. Also provide screenshots to show that the RocketMQ cluster is healthy after the changes.make manifeststo make sure the CRD files are updated.