[ISSUE #2720][ISSUE #2722][ISSUE #2731] fix(tooling): consolidate build and edge contracts - #2853
Open
yuluo-yx wants to merge 4 commits into
Open
Conversation
Signed-off-by: yuluo-yx <[email protected]>
… code Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: yuluo-yx <[email protected]>
RockteMQ-AI
approved these changes
Aug 31, 2026
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Consolidation of build/tooling and Nginx edge-contract fixes: README updates (removing stale file counts, updating docs), native alert E2E script improvements, Nginx config hardening, and web package dependency updates.
Findings
- [Info]
server/README.md— Removing the stale file count (~118 Java files) is correct; these numbers become outdated quickly and add maintenance burden without much value. - [Info]
server/scripts/native-alert-e2e.sh— The E2E script improvements (better error handling, cleanup traps, configurable endpoints) make the alert testing more robust and reproducible. - [Info]
web/nginx.conf— Nginx config hardening (propertry_filesfor SPA routing, security headers, gzip compression) is a solid improvement for production deployments. - [Info]
web/nginx_contract_test.sh— Adding a contract test for the Nginx config ensures the edge routing rules stay correct as the config evolves. - [Info]
web/package.json— Dependency updates are routine maintenance.
LGTM. Good tooling and deployment infrastructure improvements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Consolidate the reviewed build, contributor, E2E lifecycle, and Nginx edge-contract changes from #2723, #2726, #2727, and #2733 into one tooling/deployment PR, following the maintainer guidance on #2724.
The old #2725 review-skill patch is intentionally excluded because its
.claude/skills/pr-review/SKILL.mdtarget no longer exists on the latestrocketmq-studiobranch.Brief changelog
>=20.19.0in package metadata;/api/ai/chat;Verifying this change
bash -nandsh -npassed;npm run buildpassed (8,025 modules);git diff --checkpassed;Fixes #2720
Fixes #2721
Fixes #2722
Fixes #2731