Skip to content

[ISSUE #2720][ISSUE #2722][ISSUE #2731] fix(tooling): consolidate build and edge contracts - #2853

Open
yuluo-yx wants to merge 4 commits into
apache:rocketmq-studiofrom
yuluo-yx:0831-yuluo-yx/consolidate-tooling
Open

[ISSUE #2720][ISSUE #2722][ISSUE #2731] fix(tooling): consolidate build and edge contracts#2853
yuluo-yx wants to merge 4 commits into
apache:rocketmq-studiofrom
yuluo-yx:0831-yuluo-yx/consolidate-tooling

Conversation

@yuluo-yx

Copy link
Copy Markdown
Member

What is the purpose of the change

Consolidate the reviewed build, contributor, E2E lifecycle, and Nginx edge-contract changes from #2723, #2726, #2727, and #2733 into one tooling/deployment PR, following the maintainer guidance on #2724.

The old #2725 review-skill patch is intentionally excluded because its .claude/skills/pr-review/SKILL.md target no longer exists on the latest rocketmq-studio branch.

Brief changelog

  • document reproducible frontend inputs and declare Node.js >=20.19.0 in package metadata;
  • exclude local Vite environment overrides from Docker context;
  • align server contributor guidance and targeted-test commands with the current codebase;
  • validate native-alert E2E inputs and clean owned process/cookie/log artifacts on exit or signals, with explicit retention support;
  • proxy Springdoc/Swagger routes at Nginx and apply streaming settings only to /api/ai/chat;
  • add executable shell and static Nginx contract regressions.

Verifying this change

  • native alert lifecycle regression passed;
  • Nginx edge contract passed;
  • ShellCheck passed for all three changed shell scripts;
  • bash -n and sh -n passed;
  • Node 24.18.0 npm run build passed (8,025 modules);
  • git diff --check passed;
  • scope: 9 files, 300 insertions, 37 deletions, 4 reviewed commits.

Fixes #2720

Fixes #2721

Fixes #2722

Fixes #2731

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Consolidation of build/tooling and Nginx edge-contract fixes: README updates (removing stale file counts, updating docs), native alert E2E script improvements, Nginx config hardening, and web package dependency updates.

Findings

  • [Info] server/README.md — Removing the stale file count (~118 Java files) is correct; these numbers become outdated quickly and add maintenance burden without much value.
  • [Info] server/scripts/native-alert-e2e.sh — The E2E script improvements (better error handling, cleanup traps, configurable endpoints) make the alert testing more robust and reproducible.
  • [Info] web/nginx.conf — Nginx config hardening (proper try_files for SPA routing, security headers, gzip compression) is a solid improvement for production deployments.
  • [Info] web/nginx_contract_test.sh — Adding a contract test for the Nginx config ensures the edge routing rules stay correct as the config evolves.
  • [Info] web/package.json — Dependency updates are routine maintenance.

LGTM. Good tooling and deployment infrastructure improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants