[ISSUE #2728][ISSUE #2730][ISSUE #2732] fix(ops): consolidate asset workflows - #2852
Open
yuluo-yx wants to merge 3 commits into
Open
[ISSUE #2728][ISSUE #2730][ISSUE #2732] fix(ops): consolidate asset workflows#2852yuluo-yx wants to merge 3 commits into
yuluo-yx wants to merge 3 commits into
Conversation
Signed-off-by: yuluo-yx <[email protected]>
…width Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: yuluo-yx <[email protected]>
RockteMQ-AI
approved these changes
Aug 31, 2026
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Consolidation of operations-asset fixes: Grafana dashboard generator refactored from sequential y_stack to proper bin-packing layout_panels, gauge panel min moved to correct location, alert rule asset download fixes, and generated JSON files updated.
Findings
- [Info]
gen_grafana_dashboards.py:135-163— Thelayout_panelsfunction is a significant improvement overy_stack. It properly packs panels into rows respectingGRID_WIDTH=24, handles variable-width panels, and doesn't mutate the input definitions. The validation for width/height bounds is a good defensive addition. - [Info]
gen_grafana_dashboards.py:66-69— Movingmin: 0fromcustomtodefaultsis the correct Grafana JSON structure for gauge panels. - [Info]
gen_grafana_dashboards.py:175-187— Extractinggenerate_dashboardsas a testable function with anout_dirparameter enables the unit tests to verify output without touching the real resource directory. - [Info]
AlertRuleAssetList.tsx— The download endpoint fix and content-type handling are correct. - [Info] Test coverage includes layout algorithm tests with edge cases (overflow to next row, single full-width panel, mixed widths).
LGTM. Clean refactoring with proper test isolation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Consolidate the reviewed operations-asset fixes from #2735, #2736, and #2737 into one cohesive PR for alert assets, Grafana generation, and asset downloads, following the maintainer note on #2724.
The current behavior can mix mock alert-rule domains, place every generated Grafana panel at x=0, emit gauge minima outside Grafana's expected defaults, and launch duplicate downloads before React loading state becomes visible.
Brief changelog
fieldConfig.defaults.minand regenerate all 12 dashboards;Verifying this change
npm run buildpassed (8,025 modules);git diff --checkpassed;Fixes #2728
Fixes #2730
Fixes #2732