[bug] fix RepicatorCheckpointTask add acl ak/sk

[LittleBoy18]

What is the purpose of the change

fix [ISSUE #550]

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

• Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
• Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
• Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

[RockteMQ-AI]

Review: Approved ✅

PR: #551 — Fix ReplicatorCheckpointTask add ACL ak/sk
Type: Bug fix (1 file, +4/-0)

Assessment

Adds missing ACL access key/secret key configuration to the replicator checkpoint task. Minimal 4-line fix.

Verdict

✅ Correct fix for missing ACL credentials in replicator checkpoint flow.

---

🤖 Automated review by oss-sentinel-ai

[RockteMQ-AI]

Summary

Bug fix for ACL credential propagation in ReplicatorCheckpointTask. The PR adds the missing access key and secret key configuration for both source and destination endpoints, which are required when ACL is enabled on RocketMQ clusters.

Findings

• [Info] The fix is minimal and targeted — it only adds the four missing credential fields without changing other logic.
• [Info] Consider adding a unit test that verifies the credentials are properly propagated when ACL is enabled, to prevent regression.

Suggestions

The fix is correct and necessary for ACL-enabled deployments.

---

Automated review by github-manager-bot

[RockteMQ-AI]

LGTM — ReplicatorCheckpointTask.fillConnectorConfig() was missing ACL credential propagation for both source and destination endpoints. This would cause checkpoint replication to fail in ACL-enabled clusters. Fix correctly passes accessKey/secretKey for both src and dest.

---

Automated review by github-manager-bot

[RockteMQ-AI]

Summary

Correct fix for missing ACL credential propagation in ReplicatorCheckpointTask. The fillConnectorConfig() method was setting destAclEnable and srcAclEnable but not propagating the actual access key / secret key values, which would cause authentication failures when ACL is enabled.

The fix adds the four missing setDestAccessKey/setDestSecretKey/setSrcAccessKey/setSrcSecretKey calls, consistent with how other replicator tasks handle ACL config.

Minor suggestions:

• Consider adding a null/empty check on the config values to avoid setting null credentials silently
• The PR description could benefit from more detail about the reproduction scenario (currently has XX/XXXX placeholders)

Overall a good fix for a real bug.

LGTM.

---

Automated review by github-manager-bot