Skip to content

PHOENIX-7969 Update supported client versions in backward compatibility #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ishitadixit-dot wants to merge 2 commits into
base: master
Choose a base branch
from
+151 −48
Open

PHOENIX-7969 Update supported client versions in backward compatibility #2584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65b66dd
PHOENIX-7969 Update supported client versions in backward compatibili…
ishitadixit-dot Jul 24, 2026
72fc765
PHOENIX-7969 Rename loop variables per review feedback
ishitadixit-dot Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions phoenix-core/src/it/java/org/apache/phoenix/end2end/BackwardCompatibilityTestUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,14 +139,18 @@ public static List<ClientVersionGroup> computeClientVersionGroups() throws Excep
BackwardCompatibilityIT.class.getClassLoader().getResourceAsStream(COMPATIBLE_CLIENTS_JSON)) {
assertNotNull(inputStream);
JsonNode jsonNode = mapper.readTree(inputStream);
JsonNode HBaseProfile = jsonNode.get(hbaseProfile);
List<MavenCoordinates> artifacts = new ArrayList<>();
for (final JsonNode clientVersion : HBaseProfile) {
artifacts.add(mapper.treeToValue(clientVersion, MavenCoordinates.class));
JsonNode hbaseProfileNode = jsonNode.get(hbaseProfile);
if (hbaseProfileNode == null) {
return clientVersionGroups;
}
if (!artifacts.isEmpty()) {
MavenCoordinates primary = artifacts.get(0);
clientVersionGroups.add(new ClientVersionGroup(primary, artifacts));
for (final JsonNode clientVersionGroupNode : hbaseProfileNode) {
List<MavenCoordinates> artifacts = new ArrayList<>();
for (final JsonNode artifactNode : clientVersionGroupNode) {
artifacts.add(mapper.treeToValue(artifactNode, MavenCoordinates.class));
}
if (!artifacts.isEmpty()) {
clientVersionGroups.add(new ClientVersionGroup(artifacts.get(0), artifacts));
}
}
}
return clientVersionGroups;
Expand Down
181 changes: 140 additions & 41 deletions phoenix-core/src/it/resources/compatible_client_versions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,50 +1,149 @@
{
"_comment": "Lists all phoenix compatible client versions against the current branch version for a given hbase profile.",
"2.4": [
Comment thread
sanjeet006py marked this conversation as resolved.
{
"artifactId": "phoenix-client-hbase-2.4",
"version": "5.1.2"
}
[
{
"artifactId": "phoenix-client-hbase-2.4",
"version": "5.1.2"
}
]
],
"2.5": [
{
"artifactId": "phoenix-client-hbase-2.5",
"version": "5.1.3"
}
[
{
"artifactId": "phoenix-client-embedded-hbase-2.5",
"version": "5.2.2"
},
{
"artifactId": "sqlline",
"version": "1.9.0",
"groupId": "sqlline"
},
{
"artifactId": "jline-terminal",
"version": "3.12.1",
"groupId": "org.jline"
},
{
"artifactId": "jline-reader",
"version": "3.12.1",
"groupId": "org.jline"
},
{
"artifactId": "jline-builtins",
"version": "3.12.1",
"groupId": "org.jline"
},
{
"artifactId": "log4j-1.2-api",
"version": "2.25.3",
"groupId": "org.apache.logging.log4j"
}
],
[
{
"artifactId": "phoenix-client-embedded-hbase-2.5",
"version": "5.3.2"
},
{
"artifactId": "sqlline",
"version": "1.9.0",
"groupId": "sqlline"
},
{
"artifactId": "jline-terminal",
"version": "3.12.1",
"groupId": "org.jline"
},
{
"artifactId": "jline-reader",
"version": "3.12.1",
"groupId": "org.jline"
},
{
"artifactId": "jline-builtins",
"version": "3.12.1",
"groupId": "org.jline"
},
{
"artifactId": "log4j-1.2-api",
"version": "2.25.3",
"groupId": "org.apache.logging.log4j"
},
{
"artifactId": "commons-logging",
"version": "1.2",
"groupId": "commons-logging"
}
]
],
"2.6": [
{
"artifactId": "phoenix-client-embedded-hbase-2.6",
"version": "5.2.1"
},
{
"artifactId": "phoenix-core-client",
"version": "5.2.1"
},
{
"artifactId": "sqlline",
"version": "1.9.0",
"groupId": "sqlline"
},
{
"artifactId": "jline-terminal",
"version": "3.12.1",
"groupId": "org.jline"
},
{
"artifactId": "jline-reader",
"version": "3.12.1",
"groupId": "org.jline"
},
{
"artifactId": "jline-builtins",
"version": "3.12.1",
"groupId": "org.jline"
},
{
"artifactId": "log4j-1.2-api",
"version": "2.18.0",
"groupId": "org.apache.logging.log4j"
}
[
{
"artifactId": "phoenix-client-embedded-hbase-2.6",
"version": "5.2.2"
},
{
"artifactId": "sqlline",
"version": "1.9.0",
"groupId": "sqlline"
},
{
"artifactId": "jline-terminal",
"version": "3.12.1",
"groupId": "org.jline"
},
{
"artifactId": "jline-reader",
"version": "3.12.1",
"groupId": "org.jline"
},
{
"artifactId": "jline-builtins",
"version": "3.12.1",
"groupId": "org.jline"
},
{
"artifactId": "log4j-1.2-api",
"version": "2.25.3",
"groupId": "org.apache.logging.log4j"
}
],
[
{
"artifactId": "phoenix-client-embedded-hbase-2.6",
"version": "5.3.2"
},
{
"artifactId": "sqlline",
"version": "1.9.0",
"groupId": "sqlline"
},
{
"artifactId": "jline-terminal",
"version": "3.12.1",
"groupId": "org.jline"
},
{
"artifactId": "jline-reader",
"version": "3.12.1",
"groupId": "org.jline"
},
{
"artifactId": "jline-builtins",
"version": "3.12.1",
"groupId": "org.jline"
},
{
"artifactId": "log4j-1.2-api",
"version": "2.25.3",
"groupId": "org.apache.logging.log4j"
},
{
"artifactId": "commons-logging",
"version": "1.2",
"groupId": "commons-logging"
}
]
]
}