[python] Support pypaimon-rust 0.4#8856
Open
shyjsarah wants to merge 1 commit into
Open
Conversation
| ], | ||
| 'sql': [ | ||
| 'pypaimon-rust>=0.3.0,<0.4.0; python_version>="3.10"', | ||
| 'pypaimon-rust>=0.3.0,<0.5.0; python_version>="3.10"', |
Contributor
There was a problem hiding this comment.
pypaimon-rust 0.4 is built against datafusion-ffi 54, whose ABI is incompatible with
52/53 and future 55+. Could we pin datafusion to datafusion>=54,<55 and add a real
PaimonCatalog registration test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
pypaimon[sql]currently capspypaimon-rustbelow 0.4.0. After paimon-rust bumped its workspace version to 0.4.0, installing the source-built Python binding followed bypypaimon[sql]makes pip reject the installed binding and try to resolve an older wheel.Changes
pypaimon[sql]in that lane so CI verifies the package metadata accepts the source-built binding.Testing
python -m pip install --dry-run './paimon-python[sql]'recognizes the installedpypaimon-rust 0.4.0..github/workflows/paimon-python-checks.ymlas YAML.git diff --check.