[core] Reject non-positive global index read thread counts#8853
Merged
JingsongLi merged 2 commits intoJul 27, 2026
Conversation
Non-positive global-index.thread-num values create a semaphored executor without available permits, causing global index reads to block on task submission. Fail fast with a clear validation error and cover zero and negative values. Signed-off-by: QuakeWang <[email protected]>
ArnavBalyan
reviewed
Jul 27, 2026
| createCachedThreadPool(Runtime.getRuntime().availableProcessors(), THREAD_NAME); | ||
|
|
||
| public static synchronized ExecutorService getExecutorService(int threadNum) { | ||
| checkArgument(threadNum > 0, "Option 'global-index.thread-num' must be greater than 0."); |
Member
There was a problem hiding this comment.
nit: Would it be helpful to add this in the option description for generated config docs?
public static final ConfigOption<Integer> GLOBAL_INDEX_THREAD_NUM =
key("global-index.thread-num")
.intType()
.defaultValue(32)
.withDescription(
"The maximum number of concurrent threads for global index I/O.");
+ Must be greater than 0.
Signed-off-by: QuakeWang <[email protected]>
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
global-index.thread-numaccepted zero or negative values, creating a semaphored executor without available permits and causing global index reads to block during task submission.Validate the thread count at the shared pool boundary and fail fast with a clear error.
Tests
mvn -pl paimon-core -am -DfailIfNoTests=false -DwildcardSuites=none -Dtest=GlobalIndexReadThreadPoolTest test