[OPENJPA-2979] Support composite ids in getReference(entity) - #188
Merged
Merged
Conversation
Derive the object id from the instance's state manager or its primary key fields instead of reading a single id field, resolve metadata for generated subclasses and fail with a clear message when no id is set.
solomax
approved these changes
Sep 15, 2026
cristof
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getReference(entity)only read the primary key for entities with a single id field, so IdClass and EmbeddedId entities failed with a misleading "null pk" error. The id is now derived via the state manager orApplicationIds, and the entity class is resolved through superclasses so runtime subclasses work. An instance without an assigned id fails with a clear message;TestGetReferenceByEntitycovers single, IdClass and EmbeddedId ids for managed, detached and new instances.