[OPENJPA-2977] Stop mutating PersistenceConfiguration and honour mapping files - #186
Merged
Merged
Conversation
…ing files convert() no longer writes into the caller's configuration. The derived OpenJPA properties are returned by toProperties() on a copy of the configuration properties, the managed classes and mapping files are wired into the persistence unit info, and a user supplied MetaDataFactory is merged as a proper plugin string. Drop the unused PersistenceProductDerivation.load(PersistenceConfiguration, Map).
solomax
reviewed
Sep 15, 2026
solomax
reviewed
Sep 15, 2026
solomax
reviewed
Sep 15, 2026
solomax
approved these changes
Sep 16, 2026
cristof
added this pull request to stack #191
September 17, 2026 21:09
cristof
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PersistenceUnitInfoImpl.convert()no longer writes into the caller'sPersistenceConfiguration; the derived OpenJPA properties go into a copy, andmappingFiles()are now wired into the persistence unit. This also fixes merging a user suppliedopenjpa.MetaDataFactory, which broke when creating a second EMF from the same configuration, and drops the unusedPersistenceProductDerivation.load(PersistenceConfiguration, Map).