[OPENJPA-2954] Publish the cached AttributeConverter instance safely - #185
Merged
Merged
Conversation
FieldMetaData and ConverterElementHandler are shared across brokers and threads. Make the lazily populated converter caches volatile and create the converter instance with double-checked locking so exactly one instance is published. Document that converter instances are shared and must be thread-safe.
solomax
approved these changes
Sep 15, 2026
cristof
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FieldMetaDataandConverterElementHandlerare shared across brokers and threads, but they cached the converter instance and its methods in plain fields. Those fields are nowvolatile, and the instance is created with double-checked locking, so exactly one fully constructed converter is shared. New race tests check this, and the javadoc now says converters must be thread-safe.