[MRELEASE-799] Preserve explicit previous-version property references - #1500
Open
goutamadwant wants to merge 1 commit into
Open
goutamadwant wants to merge 1 commit into
goutamadwant wants to merge 1 commit into
Conversation
Retain locally resolved property references to a different original artifact version across the shared POM rewrite phases. Cache original values before mutation and reject conflicting shared-property changes regardless of reference order. Add native regression coverage including CI-friendly version rewriting. Fixes apache#1004.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1004 (MRELEASE-799).
release:update-versionsfails when a plugin dependency references a reactor artifact's previous release through a property, while the equivalent literal version is preserved. For example, a project at2.0-SNAPSHOTusing its own1.0release through${previous.version}cannot advance to2.1-SNAPSHOT.Preserve locally defined literal property values that refer to a different original artifact version. Cache original values as version references are visited, including CI-friendly properties before project-version rewriting. After rewriting, reject shared properties that would change a preserved reference. This retains conflict detection regardless of reference order and applies through the shared POM rewrite phases.
Validation:
release:update-versionsadvances the project and retains${previous.version}at1.0.mvn -Prun-its verifypassed with Maven 3.9.16 and Java 21.This change is limited to locally resolvable literal property values; it does not add resolution of inherited properties or composed expressions.
Checklist:
mvn -Prun-its verify.mvn -Prun-its verify.