Preserve Git repository URLs for non-root release POMs - #1499
Open
goutamadwant wants to merge 1 commit into
Open
goutamadwant wants to merge 1 commit into
goutamadwant wants to merge 1 commit into
Conversation
Fixes apache#1457. Keep Git SCM URLs intact when aligning the release descriptor for nested reactor POMs. Preserve existing directory alignment for other providers and cover tag, branch, and rollback execution paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1457.
When a reactor POM is below the Git checkout root, release descriptor alignment removes path segments from the Git repository URL. For example,
parent/pom.xmlchangesscm:git:https://example.com/team/project.gittoscm:git:https://example.com/team, so pushing the release tag fails.Preserve Git repository URLs in the shared descriptor alignment used by tag, branch, and rollback. Other SCM providers retain their existing directory alignment.
Validation:
mvn -Prun-its verifypassed with Maven 3.9.16 and Java 21.Checklist:
mvn -Prun-its verify.mvn -Prun-its verify.