Repository navigation
[mvnd-1.x] Honour an explicit false on a VOID command-line option - #1883
Open
arturobernalg wants to merge 2 commits into
Open
arturobernalg wants to merge 2 commits into
arturobernalg wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Environment#getCommandLineOptionalways returned a non-null value for a VOID-type option (e.g.mvnd.serial) whenever any of its prefixes matched, regardless of what followed.-Dmvnd.serial=falseand--serial=falsewere therefore indistinguishable from--serial, so an explicit "false" turned serial mode ON instead of leaving it off.Inspect the text after the matched prefix and treat an explicit "false" (case-insensitive) as turning the option off.
Backport of the
Environment.javapart of #1855 from master, adapted to this branch: mvnd-1.x has since diverged (DefaultClient.javais split intojava-mvnd/java-fallbacksource sets here, unlike master's single source set), so this backport is scoped to the independently reproducible and testable VOID-option bug. The other fixes bundled in #1855 (blank-argument handling, maven.config-aware threads/builder defaults, active-daemon log purge) touch the java-mvnd-onlyDefaultClientclass, which this branch's test-compile classpath cannot resolve against (it resolves symbols against the java-fallback class instead), so they are left for a separate change.Added
EnvironmentTest#voidOptionHonoursExplicitFalse, which fails on the current code and passes with the fix. Fullclient+commonsuite: 15/15 tests green. Checkstyle: no new violations on the touched lines (the branch has pre-existing, unrelated violations elsewhere).To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
check one of the following: