Capture embedded executor properties per execution - #53
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
Snapshot system properties when an execution begins so a reusable embedded executor preserves caller changes made between runs. Add a regression test covering a replaced system properties object. Co-authored-by: Codex <[email protected]> Signed-off-by: Efe Gökdemir <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #46 by snapshotting system properties when each embedded Maven execution begins. Reusable executors now preserve caller changes made between executions instead of restoring a constructor-time snapshot.
Changes
EmbeddedMavenExecutor.execute().Testing
JAVA_HOME=/opt/homebrew/opt/openjdk@21 mvn -pl maven-executor -Dtest=EmbeddedMavenExecutorTest#preservesSystemPropertiesSetBetweenExecutions test— PASS.JAVA_HOME=/opt/homebrew/opt/openjdk@21 mvn -pl maven-executor -DskipTests verify— PASS.JAVA_HOME=/opt/homebrew/opt/openjdk@21 mvn -pl maven-executor test— 60 passed, 1 existing baseline failure indefaultFs4CaptureOutputWithForcedColor; the same failure reproduces on the unmodifiedmainbranch.git diff --check— PASS.Notes
No competing open PR was found for #46 during the final duplicate check. AI assistance was used; the submitter has reviewed the complete diff and is responsible for the change.