Skip to content

chore: add ASF headers to session status files - #3592

Closed
Astro-Han wants to merge 1 commit into
mainfrom
fix/asf-headers-tui-session-status
Closed

chore: add ASF headers to session status files#3592
Astro-Han wants to merge 1 commit into
mainfrom
fix/asf-headers-tui-session-status

Conversation

@Astro-Han

Copy link
Copy Markdown
Contributor

Problem

main is currently red: npm run check:asf-headers fails with

2 file(s) are missing the ASF license header:
  packages/cli/src/__tests__/tui-session-status.test.ts
  packages/cli/src/tui-session-status.ts

Both files were introduced by #3441. Its CI ran at 2026-08-22T05:55Z, while the ASF source header gate landed later the same day in c633ea5 (2026-08-22T13:48Z), so the PR's green predates the gate and the files merged without headers.

What changes

Headers added by the repository's own tool, npm run write:asf-headers. Nothing else is touched.

Note

This is repair for a merge I performed on a stale green check. Flagging the process gap rather than just the file fix: a check that is green on the exact head can still predate a gate that landed on the base afterwards, so exact-head green needs a freshness dimension too, not only a commit-identity one.

The ASF source header gate landed after #3441's CI run, so its two new
files merged without headers and `check:asf-headers` now fails on main.
Generated with `npm run write:asf-headers`; no other change.

@M4n5ter M4n5ter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review of exact head 4a4e10901b8f374b00b792320cb192e68cbd05ca: APPROVE — no P0–P3 findings.

The patch adds exactly the canonical 19-line ASF block header to the two previously uncovered TypeScript files and makes no executable-code changes. node scripts/asf-license-headers.mjs check audited 2,757 covered + 130 reviewed exclusions and passed; git diff --check and the current-main merge tree are clean. The exact-head hosted test check is completed / success. All three review endpoints were empty at publication time.

中文

独立审查绑定精确 head 4a4e10901b8f374b00b792320cb192e68cbd05caAPPROVE,无 P0–P3。 变更仅为两个遗漏的 TypeScript 文件各补仓库标准 19 行 ASF header,没有可执行代码变化。header 审计覆盖 2,757 个文件 + 130 个已审排除项并通过;git diff --check、当前 main merge-tree 和 exact-head hosted test 均通过。发布时三类 review 端点均为空。

@Astro-Han

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate: #3589 fixed the same two files and merged at 10:07:36Z, a couple of minutes after I opened this. main is green again on dcebc1e25 and both files carry the header, so there is nothing left for this PR to do.

Apologies for the noise — I opened this without checking whether a fix was already in flight, which is exactly the duplicate-work check I should have run first. Thanks to @1625567290 for getting there first, and to the reviewer who approved this one for the wasted round.

@Astro-Han Astro-Han closed this Aug 23, 2026
@Astro-Han
Astro-Han deleted the fix/asf-headers-tui-session-status branch August 23, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants