fix(desktop): synchronize session row metadata with menu state - #3470
Merged
Conversation
Generated-by: Codex
Astro-Han
approved these changes
Aug 22, 2026
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
Thanks — this is a focused fix at the existing controlled-menu seam. I reviewed exact head dff8838ce4dc63f04dbf5d6249443c103a664827; the DOM projection follows the same menuOpen state that owns dismissal and focus handoff, the selector does not affect project rows, and the pointer/keyboard regression coverage matches the behavior. I found no P0–P3 issues, and the current-head test check is green.
AI-assisted review disclosure: OpenAI Codex performed an independent exact-head review. I verified the state ownership, event/lifecycle paths, tests, live review state, mergeability, and current-head CI, and I independently made the approval decision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
before:

after:

Verification
npm run build:with-depsfromapps/desktopnpm --workspace @maka/desktop run typechecknpx biome check apps/desktop/e2e/sidebar-project-row.spec.ts apps/desktop/src/renderer/styles/sidebar.css packages/ui/src/session-history-list.tsxnpx playwright test --config e2e/playwright.config.ts e2e/sidebar-project-row.spec.ts— 3 passedgit diff --checkThe focused regression failed before the controlled menu-state wiring was added.
AI use
Select exactly one:
Tool(s) and scope: Codex analyzed the popover/focus timing, implemented the controlled-state CSS fix, and extended Electron E2E coverage.
Checklist
Does this PR entail a change in behavior?