Fix ThreadContextTestAccess out of the org.apache.logging.log4j.core package - #4315
Open
ramanathan1504 wants to merge 1 commit into
Open
Fix ThreadContextTestAccess out of the org.apache.logging.log4j.core package#4315ramanathan1504 wants to merge 1 commit into
ThreadContextTestAccess out of the org.apache.logging.log4j.core package#4315ramanathan1504 wants to merge 1 commit into
Conversation
…` to eliminate split package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
log4j-core-testhad one class directly inorg.apache.logging.log4j.core, the packagelog4j-corealso exports. JPMS forbids reading one package from two modules, so aconsumer requiring both fails:
That is what fails
integration-test (3.0.0-SNAPSHOT)onlog4j-nashorn-test.2.xhas no class in that package.The class only touches public API and reaches
resetThreadContextMapby reflection, so the placement is vestigial. One call site, updated here.