Core: Preserve null operations in inspect.snapshots#3707
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
snapshotsmetadata table declaresoperationas nullable because snapshots without a summary do not have an operation. However,InspectTable.snapshots()converted the missing value withstr(None), returning the literal string"None"instead of null.This change passes the operation directly to PyArrow, preserving null semantics and matching Apache Iceberg Java's snapshots metadata table.
Are these changes tested?
Yes. A regression test creates a snapshot without a summary and verifies that
table.inspect.snapshots()returns a null operation.The following checks pass locally:
PYTHONPATH=. uv run pytest tests/table/test_inspect.py -q(5 passed)PYTHONPATH=. uv run --extra datafusion --extra pyiceberg-core pytest tests/table -q(328 passed)make lintAre there any user-facing changes?
Yes. For snapshots without a summary,
table.inspect.snapshots()now returns null in theoperationcolumn instead of the string"None". There are no API changes.