Skip to content

[plan][java][python] Reject unsafe Bash redirects - #1079

Merged
wenjin272 merged 1 commit into
apache:mainfrom
linhongyu510:fix/bash-validator-security-1004
Sep 2, 2026
Merged

[plan][java][python] Reject unsafe Bash redirects#1079
wenjin272 merged 1 commit into
apache:mainfrom
linhongyu510:fix/bash-validator-security-1004

Conversation

@linhongyu510

Copy link
Copy Markdown
Contributor

Linked issue #1004.

Summary

  • Default: reject file redirects; preserve fd duplication/closure.

Documentation

  • doc-included

Generative AI

  • Yes

CLA / Contributor Agreement / DCO

  • I have read and understood the CLA
  • I have read and understood the Contributor Agreement
  • I have read and understood the DCO

@linhongyu510
linhongyu510 marked this pull request as ready for review August 31, 2026 12:33
@linhongyu510
linhongyu510 marked this pull request as draft August 31, 2026 12:38
@github-actions github-actions Bot added doc-label-missing The Bot applies this label either because none or multiple labels were provided. fixVersion/0.4.0 priority/major Default priority of the PR or issue. labels Aug 31, 2026
@linhongyu510
linhongyu510 marked this pull request as ready for review September 1, 2026 15:50
@wenjin272 wenjin272 added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing The Bot applies this label either because none or multiple labels were provided. labels Sep 2, 2026

@wenjin272 wenjin272 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on, @linhongyu510. The overall direction looks good to me. Could you rebase onto main first though — #1083 landed in the same part of the validator and conflicts with this branch.

Reject file redirects by default while preserving file-descriptor duplication and closure. Block execution-changing environment assignments consistently across Java and Python, add regression coverage, and document the tightened security contract.

Refs apache#1004

Generated-by: TRAE (proprietary model)
@linhongyu510
linhongyu510 force-pushed the fix/bash-validator-security-1004 branch from d8042a5 to a8afb29 Compare September 2, 2026 05:47

@wenjin272 wenjin272 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments. LGTM

@wenjin272
wenjin272 merged commit ce89ead into apache:main Sep 2, 2026
27 checks passed
wenjin272 pushed a commit that referenced this pull request Sep 2, 2026
Generated-by: TRAE (proprietary model)

Co-authored-by: linhongyu510 <[email protected]>
(cherry picked from commit ce89ead)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs fixVersion/0.4.0 priority/major Default priority of the PR or issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants