FINERACT-2123: Fix Incorrect Accrual Accounting for Refund For Active Loan - #6267
Open
Bhavya-Sonigra wants to merge 3 commits into
Open
FINERACT-2123: Fix Incorrect Accrual Accounting for Refund For Active Loan#6267Bhavya-Sonigra wants to merge 3 commits into
Bhavya-Sonigra wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where cash refunds for active loans configured with accrual accounting were incorrectly debiting
INCOMEaccounts instead ofRECEIVABLEaccounts (treating active loan refunds under legacy cash-based logic).Root Cause:
In
AccrualBasedAccountingProcessorForLoan.java, thecreateJournalEntriesForRefundForActiveLoanmethod was incorrectly referencingINCOME_FROM_FEES,INCOME_FROM_PENALTIES, andINTEREST_ON_LOANS.Changes Made:
RECEIVABLEaccount types (FEES_RECEIVABLE,PENALTIES_RECEIVABLE,INTEREST_RECEIVABLE).ASSETinstead ofINCOME.ClientLoanIntegrationTest.java(testLoanRefundByCashAccrualBasedAccounting) to replace outdated Income assertions with consolidatedcheckJournalEntryForAssetAccountlogic, ensuring the test correctly validates the new receivable accounting behavior.Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
ClientLoanIntegrationTest.javaassertions to correctly validate Receivable/Asset journal entries instead of legacy Income entries for accrual refunds.)fineract-provider/src/main/resources/static/legacy-docs/apiLive.htmwith details of any API changes