FINERACT-1950: Global configuration to disallow backdated transactions - #6124
Open
Abhishek6122008 wants to merge 1 commit into
Open
Conversation
Abhishek6122008
force-pushed
the
feature/FINERACT-1950-disallow-backdated-transactions
branch
2 times, most recently
from
July 13, 2026 07:00
55f079a to
55a5827
Compare
Abhishek6122008
marked this pull request as draft
July 13, 2026 09:56
Abhishek6122008
force-pushed
the
feature/FINERACT-1950-disallow-backdated-transactions
branch
from
July 14, 2026 14:02
55a5827 to
c474a80
Compare
Abhishek6122008
marked this pull request as ready for review
July 15, 2026 06:50
Contributor
Author
|
Hi @adamsaghy and @Aman-Mittal , If any of you have time pls review my pr. The diff looks large (~450 lines) but production code is ~90 lines — the rest is unit + integration tests, plus a small test-isolation fix to SavingsAccountsTest so it no longer depends on the shared entity id=1. could a maintainer kick off the workflow run when you get a chance? Builds and passes locally. Thanks! |
Abhishek6122008
force-pushed
the
feature/FINERACT-1950-disallow-backdated-transactions
branch
from
July 23, 2026 18:10
c474a80 to
781f5f8
Compare
adamsaghy
reviewed
Jul 27, 2026
adamsaghy
reviewed
Jul 27, 2026
adamsaghy
reviewed
Jul 27, 2026
Abhishek6122008
force-pushed
the
feature/FINERACT-1950-disallow-backdated-transactions
branch
from
July 31, 2026 20:44
ceeb486 to
d3ad3f2
Compare
Contributor
|
@Abhishek6122008 Please rebase and check the failed test cases. |
Abhishek6122008
force-pushed
the
feature/FINERACT-1950-disallow-backdated-transactions
branch
4 times, most recently
from
August 4, 2026 21:59
b8118bb to
4910744
Compare
Contributor
Author
|
@adamsaghy whenever you're free, could you please run the workflow CI checks? |
Abhishek6122008
force-pushed
the
feature/FINERACT-1950-disallow-backdated-transactions
branch
3 times, most recently
from
August 14, 2026 04:15
08f15b3 to
2b3463f
Compare
Adds the disallow-backdated-transactions global configuration. When enabled, portfolio (loan and savings) transactions dated more than the configured number of days before the current business date are rejected; a value of 0 or unset allows only current-date transactions. The check lives in a single BackdatedTransactionValidationService shared by the loan and savings transaction validators, so every transaction entry point routes through one guard.
Abhishek6122008
force-pushed
the
feature/FINERACT-1950-disallow-backdated-transactions
branch
from
August 15, 2026 07:52
2b3463f to
372545c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.