Repository navigation
Conversation
Member
Author
|
The Rust counterpart uses the same header and serialization version 1. Its serialization tests consume scalar and UTF-8/raw-byte fixtures generated from this PR's |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XOR membership queries need the construction seed, segment layout, and fingerprints, but not the number of input hashes. Requiring a count in the serialized image prevents importing those fields without inventing metadata. xorf and FastFilter C also omit the count. This is a representation choice: FastFilter Java retains its input size to derive the layout.
Remove the finished filter's count and
getNumItems(),isEmpty(), andgetBitsPerItem(). Callers measuring bits per input can divide the footprint by their known input count. The builder still tracks its updates.XOR has not been released, so serialization stays at version 1. Reduce the header from 24 to 16 bytes, storing the fingerprint width, segment length, and seed. The Rust counterpart uses the same layout for 8/16-bit filters.
Validation:
mvn -B clean verifypasses all 2,335 tests, Javadocs, and license checks. XOR tests cover heapify/wrap round trips, reference fingerprints, malformed headers, and truncated images.