Repository navigation
docs: apply the style guide's "native" rules to the remaining pages #7477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Abhishek-Mohan
wants to merge
12
commits into
apache:main
Choose a base branch
from
Abhishek-Mohan:docs/7358-timezones-native
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,049
−1,036
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
39f694b
docs: apply the style guide's "native" rules to timezones.md
Abhishek-Mohan 240a8c3
Merge remote-tracking branch 'origin/main' into docs/7358-timezones-n…
Abhishek-Mohan 97a8381
docs: say which timezone expressions always use the codegen dispatcher
Abhishek-Mohan af66d07
docs: say what the date_format opt-in does and scope the rebase list
Abhishek-Mohan c9f07df
Merge remote-tracking branch 'origin/main' into docs/7358-timezones-n…
Abhishek-Mohan a1ca2e5
docs: apply the style guide's "native" rules to the remaining pages
Abhishek-Mohan 71aca66
docs: address council review of the "native" sweep
Abhishek-Mohan c4d8c5c
docs: address round 2 of the council review of the "native" sweep
Abhishek-Mohan e53d370
docs: apply the style guide's "native" rules to sql-file-tests.md
Abhishek-Mohan 6702fef
Merge remote-tracking branch 'origin/main' into docs/7358-timezones-n…
Abhishek-Mohan 0860ff0
Merge remote-tracking branch 'origin/main' into docs/7358-timezones-n…
Abhishek-Mohan 0cd1f4a
docs: address review of the "native" sweep
Abhishek-Mohan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
bit_lengthexample a few lines above has the same problem that this PR fixes insql-file-tests.md.CometBitLengthreturnsUnsupportedforBinaryTypeand does not mix inCodegenDispatchFallback, soSELECT bit_length(b)falls back to Spark (bit_length.sqlpins it withexpect_fallback(bit_length on BinaryType is not supported)). Thedispatched = Seq("bit_length")assertion would fail as written. The test name "stays native on string" also still uses a phrase that N1 rules out. Could this example use an expression that really splits by mechanism, for examplelowerwith and withoutspark.comet.caseConversion.enabled, as the SQL file page now does?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
🤖 Claude Opus 5.5 responding on behalf of @Abhishek-Mohan
Switched the example to
lower: it uses codegen dispatch by default and runs in Rust withspark.comet.caseConversion.enabled=true, aslower.sqlandlower_enabled.sqlcheck. The sentence above it now covers a config-based split too, and the test name no longer says "native".