Repository navigation
fix(dev): let the Docker build scripts run when CI is unset - #2835
Merged
Merged
Conversation
Both scripts run under `set -u`, so `${CI}` aborted with an unbound
variable error on any machine without CI set, which broke
dev/integration-tests.sh locally. Default it to empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No issue filed; small fix.
Rationale for this change
#1705 added
if test -z "${CI}"to both Docker build scripts to skip the cli and benchmarks images in CI. Both scripts run underset -u, so on any machine withoutCIset they abort before building an image:This breaks
dev/integration-tests.shand the documented local Docker build. CI never hits it because GitHub Actions setsCI=true.What changes are included in this PR?
${CI}→${CI:-}indev/build-ballista-executables.shanddev/build-ballista-docker.sh. CI behaviour is unchanged. Locally, the scripts build all images again, including the benchmarks image thatdocker-compose.ymluses.Are there any user-facing changes?
No.