Repository navigation
Conversation
Integer.parseInt(s, 16) accepts a leading '+' or '-', so the four characters after \u were not required to be hex digits. \u-03C decoded to U+FFC4 and \u++03C decoded to '<'. Throw IllegalArgumentException for any non-hex character, as is already done for other malformed values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnicodeUnescaper.translate, which backs StringEscapeUtils.unescapeJava, unescapeEcmaScript and unescapeJson, takes the four characters after
\u(or\u+) and hands them toInteger.parseInt(s, 16)without checking that they are hex digits. parseInt accepts a leading sign, sounescapeJava("\\u-03C")returns U+FFC4 (the negative value cast to char) andunescapeJava("\\u++03C")returns<. Neither is a valid Java, JSON or ECMAScript escape, and the second means a text filter looking for the canonical\u003Cform can be sidestepped by an input that this method still decodes to<.The fix rejects any non-hex character in the four-digit field with the same IllegalArgumentException the class already throws for other malformed values (for example
\u00G1). Valid input, including the\u+0047and\uuuu0047forms, decodes exactly as before. UnicodeUnescaperTest#testSignNotHexDigit fails without the main change and passes with it, and the defaultmvnbuild is green (1990 tests).This fix was found and prepared with AI assistance (Claude) and reviewed by me before submitting. The AI located the defect, wrote the patch and test, and ran the build.
mvn; that'smvnon the command line by itself.