Skip to content

Add missing @Test to CSVFormatTest.testEqualsSkipHeaderRecord#testEqualsSkipHeaderRecord() - #639

Merged
garydgregory merged 1 commit into
apache:masterfrom
sharanggupta:run-testEqualsSkipHeaderRecord
Oct 22, 2026
Merged

garydgregory merged 1 commit into
apache:masterfrom
sharanggupta:run-testEqualsSkipHeaderRecord

Conversation

@sharanggupta

Copy link
Copy Markdown
Contributor

The CSVFormat.Builder version of testEqualsSkipHeaderRecord was added without @Test when the builder was introduced (6a2376a), so it never ran. Its siblings, including testEqualsSkipHeaderRecord_Deprecated, all have @Test. This adds the annotation; the test passes, and the default mvn build passes.

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude (Anthropic) helped analyse the issue and draft the change and tests; I reviewed them against the code and ran the build.
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

The Builder version of testEqualsSkipHeaderRecord was added without
@test when CSVFormat.Builder was introduced, so it never ran. Its
siblings, including testEqualsSkipHeaderRecord_Deprecated, all have
@test.
@garydgregory
garydgregory merged commit ec4f116 into apache:master Oct 22, 2026
@garydgregory garydgregory changed the title Run CSVFormatTest.testEqualsSkipHeaderRecord Add missing @Test to CSVFormatTest.testEqualsSkipHeaderRecord Oct 22, 2026
@garydgregory garydgregory changed the title Add missing @Test to CSVFormatTest.testEqualsSkipHeaderRecord Add missing @Test to CSVFormatTest.testEqualsSkipHeaderRecord#testEqualsSkipHeaderRecord() Oct 22, 2026
garydgregory added a commit that referenced this pull request Oct 22, 2026
CSVFormatTest.testEqualsSkipHeaderRecord#testEqualsSkipHeaderRecord()
(#639)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants