Avoid reusing released APIServer response buffers - #273
Merged
popduke merged 1 commit intoAug 12, 2026
Conversation
popduke
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #272.
PubHandlerandKillHandlerpreviously reused static reference-countedByteBufinstances for validation-error responses. Once Netty released the first response, the same validation path could receive content withrefCnt == 0.This change keeps the error text as static immutable strings and creates an independently owned UTF-8 buffer for every response. The regression tests release the first response before exercising the same path again and cover all five affected validation responses.
Tests:
./mvnw -q -pl bifromq-apiserver -Dtest=PubHandlerTest,KillHandlerTest test./mvnw -q -pl bifromq-apiserver test./mvnw -q -pl bifromq-apiserver checkstyle:check./mvnw -q test