Fix test_get_python_sdk_name to use supported Python version#39328
Fix test_get_python_sdk_name to use supported Python version#39328shunping wants to merge 2 commits into
Conversation
Update sys.version_info mock from 3.9 to 3.11 in test_get_python_sdk_name and format version check error message using sys.version_info for consistency.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a test failure in the Dataflow runner's interpreter version verification logic. By updating the mocked Python version in the test suite and refining the error message format, the changes ensure that the verification logic behaves correctly and provides clearer feedback when an unsupported Python version is encountered. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the unsupported Python version exception message in the Dataflow runner's API client to display only the major and minor version numbers using sys.version_info instead of the full sys.version string. Additionally, it updates a corresponding unit test to mock Python 3.11 instead of Python 3.9. There are no review comments, so no feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Assigning reviewers: R: @damccorm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Update sys.version_info mock from 3.9 to 3.11 in test_get_python_sdk_name and format version check error message using sys.version_info for consistency.
This is needed to fix the failure of
UtilTest::test_get_python_sdk_nameon a post-release branch, where Beam version has nodevin it.Failed test run:
https://github.com/apache/beam/actions/runs/29345736526/job/87128821341?pr=39325
Traceback:
(Notice that the error message is misleading though because it does not use the mocked variable. This has also been fixed in this PR)