Repository navigation
Tell agents to stop when breeze cannot run, not use a host venv - #75599
Merged
Merged
Conversation
shahar1
changed the title
6 of 14 tasks
shahar1
marked this pull request as ready for review
October 25, 2026 06:56
shahar1
requested review from
amoghrajesh,
ashb,
choo121600,
jason810496,
jscheffl and
potiuk
as code owners
October 25, 2026 06:56
shahar1
marked this pull request as draft
October 25, 2026 07:33
amoghrajesh
reviewed
Oct 25, 2026
amoghrajesh
left a comment
amoghrajesh
left a comment
Contributor
There was a problem hiding this comment.
Intentionally draft?
1 task done
AGENTS.md said never to run pytest on the host but also listed `uv run --project` commands, and had no guidance for when breeze is unavailable. A sandboxed agent whose breeze calls were refused by the container gateway built a host virtualenv with Airflow 2.11.1 instead of reporting the failure. Narrow the host exception to the listed `uv run` commands, tell agents to stop and report when breeze cannot run, and document the breeze command for testing providers against a released Airflow version (generated from contributing-docs). Note in the magpie override that the breeze allows do not make breeze work behind the container gateway.
shahar1
force-pushed
the
docs/agents-breeze-unavailable
branch
from
October 27, 2026 07:28
d829d4c to
0620325
Compare
shahar1
marked this pull request as ready for review
October 27, 2026 07:30
shahar1
requested review from
bugraoz93,
ephraimbuddy,
gopidesupavan,
jedcunningham and
vatsrahul1001
as code owners
October 27, 2026 07:30
Contributor
Author
Had CI failures, should be good now |
shahar1
added
the
ready for maintainer review
potiuk
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a contradiction in AGENTS.md: it forbids host
pytestbut also documents specificuv run --project ... pytestchecks, so the PR names those checks as the only exception.For Breeze-dependent provider tests, agents must stop and report a gateway refusal instead of building a substitute host environment.
Adds the documented Breeze route for testing against a released Airflow version and clarifies that Magpie’s Breeze permission does not bypass gateway restrictions.
AI Summary
A sandboxed agent was asked to test the Google provider against Airflow 2.11.1. Its
breezecalls were refused by the magpie container gateway, which by design does not proxy BuildKit sessions or unlabelleddocker inspectlookups. The agent then quietly built a host virtualenv with Airflow 2.11.1 instead of reporting the failure. Two things inAGENTS.mdallowed this. It said "never run pytest on the host" while also listinguv run --project ... pytestcommands. It also gave no guidance for when breeze is unavailable, and no command for running provider tests against a released Airflow version.This PR:
uv run --projectcommands as the only exception to the host rule;breeze shell --use-airflow-version <VERSION> --mount-sources providers-and-testsroute to the generated AGENTS.md commands, via anAGENT-SKILLblock incontributing-docs/testing/unit_tests.rst;.apache-magpie-overrides/setup-isolated-setup-install.mdthat the breeze permission allows only skip the prompt and do not make breeze work behind the container gateway.Checks run locally:
prek run --from-ref upstream/main --stage pre-commitpassed, including "Sync AGENTS.md commands from contributing docs" and "Check documented breeze and prek commands exist".lychee-docker, because Docker was unavailable in the session.check-eval-hash. The skill-eval has not been re-run yet, sodev/skill-evals/last-eval-hash.txtis stale and this PR stays a draft until that hash is updated.The companion magpie change that hints agents on gateway policy refusals is apache/magpie#1810.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5.5, Sonnet 5.5) following the guidelines