Repository navigation
test(conformance): P77 verify — guard gaps, stale artifacts, record - #2751
Merged
Merged
Conversation
plan-775c50 /verify-implementation, class-cure audit: the WithStatement arm of AsyncGuardedUseAnalyzer.IsStoreTarget could be replaced by false with FullyQualifiedName~AsyncGuarded still green (25/25), although DispatchSiteInventoryTests rosters the site as netted by this type. The generator held a member store only as an assignment's target. Four uses join the generator, a member of the value as a tuple leaf and as a for / with / comprehension target, each expected Ensure, over the six non-const spellings and both views. Mutations, each on AsyncGuardedUseAnalyzer.cs alone, restored by cp and cmp, filter FullyQualifiedName~AsyncGuardedUseFactTests (3 tests): - WithStatement arm -> false: broken -> red (2 failed, 1 passed) - ForStatement arm -> false: broken -> red (2 failed, 1 passed) - ForClause arm -> false: broken -> red (2 failed, 1 passed) - IsElementOf's TupleLiteral arm -> false: broken -> red (2 failed, 1 passed) - restored -> green (3 passed) Measured @ a2876b2 plus this change. Co-Authored-By: Claude Fable 5.2 <[email protected]> Claude-Session: https://claude.ai/code/session_01LGMKZW5iXgCkmJYFuSUhUm
plan-775c50 /verify-implementation. The #2588 cell asserted that stdout does not contain "main", but ProjectCompilationHelper returns an empty stdout whenever the program throws, so the absence had no positive control: a Main that ran the user's body first and the sweep after it stayed green. main now raises its own ValueError, and the test asserts that the exception under the reflection wrapper is exactly ZeroDivisionError: the sweep ran first, and nothing wraps what it raised (D3; Q3). Mutation, RoslynEmitter.ModuleClass.cs: Main's __Load() appended to its body in place of inserted first; filter FullyQualifiedName~StaticInitSweepProjectTests (5 tests): broken -> red (1 failed, 4 passed: found "ValueError"); restored by cp and cmp -> green (5 passed). Measured @ a2876b2 plus this change. Co-Authored-By: Claude Fable 5.2 <[email protected]> Claude-Session: https://claude.ai/code/session_01LGMKZW5iXgCkmJYFuSUhUm
plan-775c50 /verify-implementation, stale artifacts (contract section 11): - initializer-dependency-differential-allowlist.txt held 0 rows since 086a550 and was never deleted. The test reads a missing file as empty (the ratchet stays), it has no seed line and no pin entry. - scorecard_metrics.py --lower: allowlist_rows_seed 2379 -> 2377, the two rows 410a688 drained without lowering. --check: RESULT OK. - Two comments that still described drained rows or a retired SPY0618 in the present tense now say what holds: SPY0618's forward-read rule is retired, the code stays for N2's shape (owner ruling, 2026-11-17). No assertion changes. The generator's run with the file absent is recorded in the plan's verification record. Co-Authored-By: Claude Fable 5.2 <[email protected]> Claude-Session: https://claude.ai/code/session_01LGMKZW5iXgCkmJYFuSUhUm
plan-775c50 /verify-implementation, two docs findings in parameter_modifiers.md: - Deferred finding F14 asked the spec to name both moves of an out operand on a value not yet initialized. The NameError inside the value's own initializer was there; the callee's read by name before the initializer was not. New block: 7 42 @ a2876b2, 42 7 @ 6d6c5c9 (the ruling is Q-F (a) of the plan's verification summary). - The ref / in example ran its operands from main, where every value is ready at the base too (2 3 3 at both shas), so it did not show "initialized first". It now runs them from an earlier initializer: 3 2 3 @ a2876b2, 0 1 3 @ 6d6c5c9. Both blocks carry the output marker and were run with sharpyc run (Debug). Co-Authored-By: Claude Fable 5.2 <[email protected]> Claude-Session: https://claude.ai/code/session_01LGMKZW5iXgCkmJYFuSUhUm
Independent review of #2751 @ c9179c2 (merge after fixes), its three findings: - F1: the comment on the new cells claimed one cell per arm of IsElementOf; only its TupleLiteral arm has one. A cell was tried for the list arm ([v.x, n0] = ...) and for the parenthesized arm ((v.x, n0) = ...): with each arm replaced by false the type stayed green (3 passed both times), because the parser gives a list target and a parenthesized tuple target a TupleLiteral (sharpyc emit ast, for an assignment, a for and a comprehension). A starred member target is SPY0106. The two vacuous cells are not added; the comment names the three arms no accepted program reaches, and why. - F2: parameter_modifiers.md says the value stays initialized after the callee's read, so its declaration does not run the initializer again. - F3: gap-discovery-contracts.md no longer describes the deleted allowlist file as present. No assertion and no cell changes against c9179c2: comments and prose only. FullyQualifiedName~AsyncGuardedUseFactTests|~DispatchSiteInventoryTests: 20 passed, 0 failed, measured on this tree. Co-Authored-By: Claude Fable 5.2 <[email protected]> Claude-Session: https://claude.ai/code/session_01LGMKZW5iXgCkmJYFuSUhUm
Appends the Implementation Verification Record: five refuting auditors over 6d6c5c9..f968835 (the merge of #2742), no regression found, six completeness gaps and two vacuous assertions fixed on this lane, eleven cells posted to seven open trackers, no issue filed. Gate, the last code commit's: 85541/0/10 @ 5a5adce (measured, run 44554132404), Python Build Tools green (run 44554139066). Co-Authored-By: Claude Fable 5.2 <[email protected]> Claude-Session: https://claude.ai/code/session_01LGMKZW5iXgCkmJYFuSUhUm
antonsynd
marked this pull request as ready for review
November 19, 2026 15:55
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P77 —
/verify-implementationof plan-775c50The implementation merged as #2742. This lane carries the verify round's remediation and, as its last commit, the
## Implementation Verification Recordin plan-775c50 (stamp CONVERGED, Adequacy CLASS, tierfull). No product code changes.Result. Five refuting auditors read
6d6c5c9b2..f968835c1(devjust before the merge against the merge; 474 files) and found no regression: nothing red at the tip that was green at the base, in any suite or in about 250 probe programs outside the generator's matrix, each run on both binaries and under CPython 3.15.2.Gate:
85541/0/10 @ 5a5adce6c (measured, run 44554132404), Python Build Tools green (run 44554139066). The tip after it,c59145b63, changes only the plan file. Baseline:85539/0/12 @ a2876b2e2 (measured, run 44517339246); the two extra skips there are coverage-only.Independent review @ c9179c2: merge after fixes; 3 applied, 0 declined (reasons below); fixes c9179c2..5a5adce read by the lead
What this pull request changes
7356ab494AsyncGuardedUseFactTests: a cell for thewith,for, comprehension and tuple-leaf arms of the async-use factwitharm could be replaced byfalsewith all 25AsyncGuarded*tests green2f2ea0234mainorder off the exception that escapesbea6f9262initializer-dependency-differential-allowlist.txtdeleted; scorecard seed baseline 2379 → 2377; two stale comments--lowerc9179c2e1parameter_modifiers.md: theoutoperand's read-by-name example (7 42;42 7at the base); aref/inexample that differs at the base (3 2 3against0 1 3)2 3 3at both5a5adce6cc59145b63Mutation outcomes
AsyncGuardedUseFactTestsfalse, one at a timeMainRequiresItsModule_AndAFailedSweepStopsBeforeMainMainloads after its bodyValueError)InitializerDependency_Sweep(the plan's one unrecorded M5 mutation)32/1/0, 92 and 220 cells red, the probe prints5 733/0/0Thirteen more guards of the plan's range were mutated by the class-cure auditor: twelve red, one vacuous (the first row above). The full table is in the record.
Class status
@staticvalue's readiness, and the emission of a reference to it, do not depend on the path, spelling or position of the use, nor on what its initializer reads.InitializerDependencyDifferentialTests— pool 3267, red 0, allowlist 0 rows, python agreed 1372 of 1372, and its allowlist file is gone.@staticproperty default, read asH._hpbefore its initializer, prints a storage default (0 7 7) under the experimentalproperty_observersflag; the base gave SPY0908. It is inside the plan's contract and is the one counterexample found to "no read returns a value never given one".sharpyc run, a loop over a@static+=and a module read is about 2.8× slower than at the base (Release: level). A host whoseTryLoadlost the lock stays unswept for the process, and its reads then take the process-wide lock, about 22–28 ns against about 0.7 ns.Issues
Refs #2422, #2412, #2420. Each meets its close criterion in the plan's "Issues to Close":
2 1@ 6d6c5c9DetectInitializerDependenciesis gone; seeds D10 and E06 print6@ a2876b2, SPY0908 CS0103 @ 6d6c5c9No issue filed: every cell had an open tracker (eleven cells, seven comments).
H._hpread, a livefromimport, the two costs, a spec sentence onrefin anasync def+=CS0200, all behind SPY0908 #2494: a narrowedint?@staticread+=through a module-qualified or generic hostIndependent review
One reviewer that wrote none of the code, read-only, given the diff and both built compilers, never the plan.
IsElementOf. I tried a cell for its list arm and its parenthesized arm: with each arm replaced byfalsethe test stayed green, because the parser gives those targets aTupleLiteral. The two vacuous cells are not added; the comment names the three arms no accepted program reaches.outparagraph: the value stays initialized, so its declaration does not run the initializer again.gap-discovery-contracts.mdno longer describes the deleted file as present.The fix round adds no guard and no abstraction, so it takes no second review.
Unresolved
🤖 Generated with Claude Code
https://claude.ai/code/session_01LGMKZW5iXgCkmJYFuSUhUm