fix(reflect): return None for string lookups on non-string maps - #470
Merged
iainmcgin merged 2 commits intoSep 26, 2026
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Only a string key compares Equal in get_str's comparator, so a hit is always a string entry and the re-check after the search was dead. Add a test over a map holding both non-string and string keys: it fails if the non-string arm returns Greater, or if String stops being MapKey's last variant. Reword the changelog fragment and cite the PR.
Collaborator
|
[claude code] Thanks for this. The fix is right: I pushed one maintainer commit (bd453a4) on top:
|
iainmcgin
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MapValue::get_strdocuments that lookups on non-string-keyed maps returnNone, but a debug assertion caused those calls to panic in debug builds.Remove the assertion and retain the existing allocation-free binary search. Integer- and boolean-keyed maps now return
Noneconsistently, including throughReflectMap.Add regression coverage for all non-string key variants and a changelog fragment.
Validation
buffa-descriptorlibrary tests pass with all features enabled.no_stdlibrary compilation pass.systemtime_roundtrip_post_epochfailure caused by nanosecond precision loss.