Repository navigation
Take the device recorder out of the repository - #33
Merged
Merged
Conversation
dev/mirror/ held the browser and SSH recorders that read a real device. They are a private tool for the maintainer's own network and have no part in CI, the packages or the contribution workflow, so they leave the tree and the directory is ignored. The request policy they shared with the replay (allowlist, body parsers, secret scrubbing) moves to dev/replay/policy.js, where the replay already needed it; its test follows as tests/policy.test.js. The recorder's end-to-end test leaves with it. Docs no longer describe how recordings are made. The replay's README gains a Recording format section (browser-*/rpc.jsonl, http.jsonl, static/, ssh-*/snapshots.jsonl) so anyone can produce or inspect one; README, CONTRIBUTING, AGENTS, SECURITY and SPEC point there. No change to the packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recorders in
dev/mirror/are a private tool for my own device, so I'm removing them from the tree and ignoring the directory. The request policy the replay shares with them moves todev/replay/policy.js, test included.The replay's README now documents the recording format instead; the other docs point there. Packages are unchanged.