Repository navigation
Fix AP uplink detection with unmanaged WAN interfaces - #32
Merged
anothaDev merged 2 commits intoOct 17, 2026
Merged
Conversation
ronger-x
marked this pull request as ready for review
October 17, 2026 12:04
luci-app-vantage: the uplink change in the previous commit moved the _() calls in model.js by four lines; regenerate the template and the zh_Hans catalogue so dev/i18n/update.sh --check passes. No strings changed.
anothaDev
added a commit
that referenced
this pull request
Oct 18, 2026
CHANGELOG.md lists the user-visible changes of every release since 1.0.1, newest first, built from the release pull requests, plus an Unreleased section for the uplink fix (#32) and the recorder removal. README: the tagline and badge now say 25.12 and 24.10, which 1.0.8 added but the homepage never mentioned; Contributing links the changelog. CONTRIBUTING: the release flow starts with the changelog entry. CI: the generated release notes link to the changelog at the tag. Repository index page: link to the changelog and the releases.
Merged
anothaDev
added a commit
that referenced
this pull request
Oct 20, 2026
A tunnel's default route has no next hop. Since #32 picks such a tunnel as the uplink when wan has no default route, the dashboard read "No default route"; it shows the tunnel device instead.
Owner
|
Released in 1.0.9, thanks! It also names the tunnel when a VPN is the uplink and has no gateway address. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An access point can retain up
wanandwan6interfaces withproto: noneafter their Ethernet port is bridged into LAN. Vantage currently selects those interfaces by name before considering default routes, so the network path reports “No default route” and loses the gateway, DNS and management address even though LAN has a valid default route.Prefer interfaces carrying an IPv4 or IPv6 default route, retaining the existing WAN-name priority within that set. If no up interface has a default route, keep the previous WAN-name/first-up fallback. Derive
isWanfrom the selected interface so an AP's routed LAN is labelled Gateway. This changes dashboard interpretation only; it does not change network configuration or RPC permissions.Regression coverage includes unmanaged WAN/WAN6 interfaces in both dump orders, IPv6 WAN selection, normal WAN preference with DSA offload, and fallback when no default route is available. Fixtures use documentation addresses only.
Validation:
node --test tests/— 292 passed, 0 failed, 15 skipped (optional tooling/fixtures unavailable).git diff --checkpassed.libgomp.so.1. No translatable strings changed. No replay mirror/rootfs was available for offline UI verification.