Repository navigation
Conversation
With no interfaces, the Networks row rendered nothing and the Download button was disabled with no explanation. Show the scan state, the reason, and a Scan again action.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With no interfaces, the New download dialog renders an empty Networks row and a disabled Download button, with no reason and no action.
The main screen already says "No networks connected" and offers Scan again; the dialog was the one place that ignored
interfacesStatus/interfacesError.This shows the scan state in the Networks group:
Test:
e2e/ui.spec.tsunder the existingno networksdescribe opens the dialog withPLEXO_E2E_INTERFACES=''and asserts the message, the Scan again button, and the disabled Download button. It fails onmain.Checks:
npm run lintnpm run format:checknpm run typechecknpm run test:e2e:smoke(119 passed)