Repository navigation
Keep the tour popover on its target when the page shifts - #480
Merged
Merged
Conversation
driver.js ignores refresh() while its highlight animation runs and places the popover halfway through it. When Home's recent projects and continue card load in during that window, the Use as project button moves and the popover stays behind. Re-place it once the animation ends and whenever the target's box changes after that. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01E2eZ9wyD5DSCaHswZ3Gy5t
…ement after animating The Use as project button often sits at the bottom of Home once recent projects and the continue card are shown, leaving no room for a popover under it, so place it above. When a step's target starts off screen, or too low for a popover meant to go below it, scroll it to the middle once. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01E2eZ9wyD5DSCaHswZ3Gy5t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Anders Hafreager · project thread
Bug
On step 2, "Start from an example", the popover stopped partway, above the Recent projects section. It only jumped to Use as project when the button was hovered.
Cause
driver.js places the popover halfway through its highlight animation and ignores
refresh()until the animation ends. Home loads the continue card and recent projects during that window, which pushes the examples down. The tour's layout-change check fired during the animation, where it did nothing, and then recorded the new position as already handled.Fix
TourControllerskips the check while driver.js is animating. Once the animation is done it re-places the popover whenever the target's box changes. If the shift pushed the target off screen, it scrolls it back into view once.Testing
e2e/tour.spec.tsnow inserts a 260px spacer above the examples right after Start, then checks that the popover sits under the button. The test fails without this fix and passes with it.Generated by Claude Code