Repository navigation
image: replace output_size with a qcow2 virtual_size - #319
Merged
Merged
Conversation
![github-actions[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
The `output_size` attribute from commit 4240a39 pads the raw disk with free space. But the main purpose of the raw is for writing to real iron and cloud images, and in both cases the real disk is larger anyway -- firstboot grows into it. All that padding is unnecessary, needs careful "sparse files" treatment, and gets in the way when trying to upload them as e.g. an AMI. The extra room is only really useful for virtual disks like qcow2 or VMDK. Keep the raw as small as its partitions, drop `output_size`, and and give the qcow2 a `virtual_size` instead. Cloud images such as an AMI will size their volume from the same attribute in the future. Signed-off-by: Martin Pitt <[email protected]>
martinpitt
force-pushed
the
virtual-size
branch
from
October 16, 2026 10:35
2b3fcf2 to
29bc9fa
Compare
daandemeyer
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
output_sizeattribute from commit 4240a39 pads the raw disk with free space. But the main purpose of the raw is for writing to real iron and cloud images, and in both cases the real disk is larger anyway -- firstboot grows into it. All that padding is unnecessary, needs careful "sparse files" treatment, and gets in the way when trying to upload them as e.g. an AMI.The extra room is only really useful for virtual disks like qcow2 or VMDK. Keep the raw as small as its partitions, drop
output_size, and and give the qcow2 avirtual_sizeinstead. Cloud images such as an AMI will size their volume from the same attribute in the future.Preparation for reworking #311