Repository navigation
tine: build with umask 022 - #314
Merged
Merged
Conversation
images.md promises 0755 for directories, but Buck creates the directories in its outputs with its own umask. A builder with umask 0002 (Debian/Ubuntu default) produced group-writable directories in every image, which sshd refuses. Signed-off-by: Martin Pitt <[email protected]>
daandemeyer
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
images.md promises 0755 for directories, but Buck creates the directories in its outputs with its own umask. A builder with umask 0002 (Debian/Ubuntu default) produced group-writable directories in every image, which sshd refuses.
I have a test for this which adds a new group with a new isolation dir with umask 002, but that's awfully involved/verbose. So I settled for a simple one which fails (without the fix) on my system.