Repository navigation
Various refactoring - #312
Merged
Merged
Conversation
kmod.py binds libkmod to select kernel modules. It depends on nothing else in image, and it has its own test and its own default pattern list. Let's move kmod.py, kmod_test.py and initrd_modules.toml into a kmod package with its own library and test targets. Signed-off-by: Daan De Meyer <[email protected]>
image.repart builds a DDI, a GPT disk image, from partition definitions, and image.bootable_disk builds its disk through the same declaration function. The rule, its provider and its driver are named after systemd-repart, the tool they run, rather than after what they build. Let's rename image.repart() to image.ddi(), RepartInfo to DdiInfo, disk.bzl to ddi.bzl and disk.py to ddi.py. No partition UUID or digest changes. Signed-off-by: Daan De Meyer <[email protected]>
image_format loads ImageInfo, the action helpers and the signing attributes from image, and image loads every rule from image_format. The two packages therefore don't form layers. The boot artifact rules are in image_format, but their drivers are in image. ddi.py also needs a visibility exception to use image:manifest-lib. Let's move image_format into image. Signed-off-by: Daan De Meyer <[email protected]>
uki.bzl builds the UKIs of a disk, and boot.bzl extracts the kernel, initrd and UKI back out of it. initrd.bzl declares a composition. install.bzl declares the rule that fills ImageInstallInfo, which image.bzl defines and consumes. Let's move uki.bzl into boot.bzl, initrd.bzl into compose.bzl and install.bzl into image.bzl. Signed-off-by: Daan De Meyer <[email protected]>
The image struct lists the thirteen layer operations next to the rules, providers and constants, so a reader can't tell which names build a layer. Let's put the operations in a nested image.ops struct, and call them as image.ops.copy() and so on. Signed-off-by: Daan De Meyer <[email protected]>
daandemeyer
force-pushed
the
push-tunsmrrzlsyw
branch
from
October 15, 2026 14:38
1a8fa96 to
57a1f04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.