Repository navigation
image_format: Record erofs inode digests - #310
Merged
Merged
Conversation
martinpitt
approved these changes
Oct 15, 2026
martinpitt
left a comment
martinpitt
left a comment
Member
There was a problem hiding this comment.
Oh, that's cool! For shared base layers of sysexts and such? Will need the "update-reproducibility" label dance once CI is finished. Not sure if you ever used it before, LMK if there are problems.
daandemeyer
force-pushed
the
push-opmsqnvyqrwp
branch
from
October 15, 2026 07:49
4b570a5 to
2ba00a5
Compare
Member
|
@daandemeyer ah sorry, the update-reproducibility workflow can't work on forks. Grab the updated sums from https://github.com/amutable-systems/tine/actions/runs/38701401848?pr=310 or re-push from origin. You already force-pushed the x86 ones yourself earlier. |
Since v7.0, Linux can share the page cache of identical files between erofs images mounted with inode_share and domain_id. It only does so for images that record a digest of each file, and our erofs images don't. Let's pass --xattr-inode-digest to mkfs.erofs for every erofs partition we build, in disks and extensions alike, unless the caller already picked a digest name. Signed-off-by: Daan De Meyer <[email protected]>
daandemeyer
force-pushed
the
push-opmsqnvyqrwp
branch
from
October 15, 2026 08:41
2ba00a5 to
7db93d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since v7.0, Linux can share the page cache of identical files between erofs
images mounted with inode_share and domain_id. It only does so for images that
record a digest of each file, and our erofs images don't. Let's pass
--xattr-inode-digest to mkfs.erofs for extensions and the secure boot example.
Signed-off-by: Daan De Meyer [email protected]